You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/13 16:43:43 UTC

[GitHub] [flink] azagrebin edited a comment on issue #11427: [FLINK-15790][k8s] Make FlinkKubeClient and its implementations asynchronous

azagrebin edited a comment on issue #11427: [FLINK-15790][k8s] Make FlinkKubeClient and its implementations asynchronous
URL: https://github.com/apache/flink/pull/11427#issuecomment-612981175
 
 
   Thanks for addressing the comments @wangyang0918 
   
   I also changed a bit test to wait for the actual pod creation with the latch and reduced the retry interval for tests to keep test run time low.
   
   One hotfix commit introduces `KubernetesResourceManagerConfiguration`. It is created by factory and  injected into the `KubernetesResourceManager`. Ideally, there should be no logic in constructor but in factories. The object should get only needed dependencies to simplify mocking them in tests.
   
   The PR looks good to me.
   If you are ok with my additions, then +1 for merging.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services