You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Tim Moloney (JIRA)" <ji...@apache.org> on 2009/06/11 18:13:07 UTC

[jira] Created: (FELIX-1220) Remove unnecssary parts of a filter

Remove unnecssary parts of a filter
-----------------------------------

                 Key: FELIX-1220
                 URL: https://issues.apache.org/jira/browse/FELIX-1220
             Project: Felix
          Issue Type: Improvement
          Components: Karaf
            Reporter: Tim Moloney
            Priority: Minor


When configuring via a feature, the filter used to get the list of configurations searches for a property name ".alias_factory_pid".  However checkKey() in the ConfigurationAdmin's CaseInsensitiveDictionary only allows keys to start with an alpha-numeric character and has an additional test to prevent keys from starting or ending with a period.  Therefore the filter can be simplified from

   (|(ALIAS_KEY=factoryPid)(.alias_factory_pid=factoryPid))

to just

   (ALIAS_KEY=factoryPid)

This same filter also appears in FileMonitor.java in Karaf's deployer.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (FELIX-1220) Remove unnecssary parts of a filter

Posted by "Tim Moloney (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-1220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tim Moloney closed FELIX-1220.
------------------------------


> Remove unnecssary parts of a filter
> -----------------------------------
>
>                 Key: FELIX-1220
>                 URL: https://issues.apache.org/jira/browse/FELIX-1220
>             Project: Felix
>          Issue Type: Improvement
>          Components: Karaf
>            Reporter: Tim Moloney
>            Assignee: Guillaume Nodet
>            Priority: Minor
>             Fix For: karaf-1.0.0
>
>         Attachments: FELIX-1220-features-configuration.patch
>
>
> When configuring via a feature, the filter used to get the list of configurations searches for a property name ".alias_factory_pid".  However checkKey() in the ConfigurationAdmin's CaseInsensitiveDictionary only allows keys to start with an alpha-numeric character and has an additional test to prevent keys from starting or ending with a period.  Therefore the filter can be simplified from
>    (|(ALIAS_KEY=factoryPid)(.alias_factory_pid=factoryPid))
> to just
>    (ALIAS_KEY=factoryPid)
> This same filter also appears in FileMonitor.java in Karaf's deployer.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (FELIX-1220) Remove unnecssary parts of a filter

Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-1220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Guillaume Nodet resolved FELIX-1220.
------------------------------------

       Resolution: Fixed
    Fix Version/s: karaf-1.0.0
         Assignee: Guillaume Nodet

URL: http://svn.apache.org/viewvc?rev=802692&view=rev


> Remove unnecssary parts of a filter
> -----------------------------------
>
>                 Key: FELIX-1220
>                 URL: https://issues.apache.org/jira/browse/FELIX-1220
>             Project: Felix
>          Issue Type: Improvement
>          Components: Karaf
>            Reporter: Tim Moloney
>            Assignee: Guillaume Nodet
>            Priority: Minor
>             Fix For: karaf-1.0.0
>
>         Attachments: FELIX-1220-features-configuration.patch
>
>
> When configuring via a feature, the filter used to get the list of configurations searches for a property name ".alias_factory_pid".  However checkKey() in the ConfigurationAdmin's CaseInsensitiveDictionary only allows keys to start with an alpha-numeric character and has an additional test to prevent keys from starting or ending with a period.  Therefore the filter can be simplified from
>    (|(ALIAS_KEY=factoryPid)(.alias_factory_pid=factoryPid))
> to just
>    (ALIAS_KEY=factoryPid)
> This same filter also appears in FileMonitor.java in Karaf's deployer.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (FELIX-1220) Remove unnecssary parts of a filter

Posted by "Tim Moloney (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-1220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tim Moloney updated FELIX-1220:
-------------------------------

    Attachment: FELIX-1220-features-configuration.patch

This patch removes the unneeded parts of the filter used to search for configurations.
This patch includes the changes in FELIX-1218-features-configuration.patch.

> Remove unnecssary parts of a filter
> -----------------------------------
>
>                 Key: FELIX-1220
>                 URL: https://issues.apache.org/jira/browse/FELIX-1220
>             Project: Felix
>          Issue Type: Improvement
>          Components: Karaf
>            Reporter: Tim Moloney
>            Priority: Minor
>         Attachments: FELIX-1220-features-configuration.patch
>
>
> When configuring via a feature, the filter used to get the list of configurations searches for a property name ".alias_factory_pid".  However checkKey() in the ConfigurationAdmin's CaseInsensitiveDictionary only allows keys to start with an alpha-numeric character and has an additional test to prevent keys from starting or ending with a period.  Therefore the filter can be simplified from
>    (|(ALIAS_KEY=factoryPid)(.alias_factory_pid=factoryPid))
> to just
>    (ALIAS_KEY=factoryPid)
> This same filter also appears in FileMonitor.java in Karaf's deployer.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.