You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2018/08/03 09:39:00 UTC
[GitHub] rtaneja1 commented on a change in pull request #647:
[NETBEANS-1108] Replace the repetitive code for error check in Hint module
rtaneja1 commented on a change in pull request #647: [NETBEANS-1108] Replace the repetitive code for error check in Hint module
URL: https://github.com/apache/incubator-netbeans/pull/647#discussion_r207493383
##########
File path: java.hints/src/org/netbeans/modules/java/hints/jdk/ConvertToVarHint.java
##########
@@ -153,7 +153,7 @@ private static boolean preConditionChecker(HintContext ctx) {
return false;
}
- if (isDiagnosticCodeTobeSkipped(ctx.getInfo(), treePath.getLeaf())) {
+ if (ctx.getInfo().getTreeUtilities().hasError(treePath.getLeaf())) {
Review comment:
Please check for SKIPPED_ERROR_CODES in removed code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists