You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by tzulitai <gi...@git.apache.org> on 2017/06/30 06:31:14 UTC

[GitHub] flink issue #3869: [FLINK-6502] Add support ElasticsearchSink for DataSet

Github user tzulitai commented on the issue:

    https://github.com/apache/flink/pull/3869
  
    @397090770 I'm afraid I will need to reject this PR as of its current state.
    
    The main issue is that we can't just move those public user-facing classes. We either have to deprecate them and have a more general packaging path for them so that they can be shared across batch / stream ES connectors, or that we simply duplicate them for batch.
    
    As for the base class logic, this PR needs refactoring so that common logic between the batch and stream is shared, instead of almost the exact same code copied between the two.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---