You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/01/12 11:02:05 UTC
[GitHub] [solr] janhoy opened a new pull request #519: Script to scaffold a new contrib module
janhoy opened a new pull request #519:
URL: https://github.com/apache/solr/pull/519
Adding a new contrib required wiring contrib-name into several gradle files, and they all need a README and a `build.gradle`. So here is a py script to scaffold a new contrib and wire it into the build. See usage in README.
Perhaps such a tool can propell the effort to lift stuff out from core into contribs. A nice detail is that solr-operator has 1st class support for adding contribs by name. I wonder if we could add such shortcut to `bin/solr` as well, e.g. `bin/solr start -c -Dcontribs=analysis-extras,langid,clustering` and the script will automatically add them to global path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on a change in pull request #519: Script to scaffold a new contrib module
Posted by GitBox <gi...@apache.org>.
janhoy commented on a change in pull request #519:
URL: https://github.com/apache/solr/pull/519#discussion_r783548683
##########
File path: dev-tools/scripts/addContrib.py
##########
@@ -0,0 +1,170 @@
+#!/usr/bin/env python3
+# -*- coding: utf-8 -*-
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+import os
+import sys
+sys.path.append(os.path.dirname(__file__))
+from scriptutil import *
+
+import argparse
+import re
+from textwrap import dedent
+
+def update_build(file_path, search_re, replace_line):
+ print('adding contrib into %s' % file_path)
+ matcher = re.compile(search_re)
+
+ def edit(buffer, match, line):
+ if replace_line in line:
+ return None
+ match = matcher.search(line)
+ if match is not None:
+ buffer.append(replace_line)
+ buffer.append(line)
+ return match is not None
+
+ changed = update_file(file_path, matcher, edit)
+ print('done' if changed else 'uptodate')
+
+
+def read_config():
+ parser = argparse.ArgumentParser(description='Scaffold new contrib module')
+ parser.add_argument("name")
+ parser.add_argument("full_name")
+ parser.add_argument("description")
+ newconf = parser.parse_args()
+ return newconf
+
+
+def get_readme_skel(conrib_name):
+ return dedent('''Apache Solr %s
+=====================================
+
+Introduction
+------------
+TBD
+
+Getting Started
+---------------
+TBD
+''' % conrib_name)
+
+def get_license_header():
+ return '''/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+'''
+
+def get_build_gradle(description):
+ return dedent('''apply plugin: 'java-library'
+
+description = '%s'
+
+configurations.all {
Review comment:
Removed slf4j-api again from the template
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy merged pull request #519: Script to scaffold a new contrib module
Posted by GitBox <gi...@apache.org>.
janhoy merged pull request #519:
URL: https://github.com/apache/solr/pull/519
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on a change in pull request #519: Script to scaffold a new contrib module
Posted by GitBox <gi...@apache.org>.
janhoy commented on a change in pull request #519:
URL: https://github.com/apache/solr/pull/519#discussion_r783147589
##########
File path: dev-tools/scripts/addContrib.py
##########
@@ -0,0 +1,170 @@
+#!/usr/bin/env python3
+# -*- coding: utf-8 -*-
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+import os
+import sys
+sys.path.append(os.path.dirname(__file__))
+from scriptutil import *
+
+import argparse
+import re
+from textwrap import dedent
+
+def update_build(file_path, search_re, replace_line):
+ print('adding contrib into %s' % file_path)
+ matcher = re.compile(search_re)
+
+ def edit(buffer, match, line):
+ if replace_line in line:
+ return None
+ match = matcher.search(line)
+ if match is not None:
+ buffer.append(replace_line)
+ buffer.append(line)
+ return match is not None
+
+ changed = update_file(file_path, matcher, edit)
+ print('done' if changed else 'uptodate')
+
+
+def read_config():
+ parser = argparse.ArgumentParser(description='Scaffold new contrib module')
+ parser.add_argument("name")
+ parser.add_argument("full_name")
+ parser.add_argument("description")
+ newconf = parser.parse_args()
+ return newconf
+
+
+def get_readme_skel(conrib_name):
+ return dedent('''Apache Solr %s
+=====================================
+
+Introduction
+------------
+TBD
+
+Getting Started
+---------------
+TBD
+''' % conrib_name)
+
+def get_license_header():
+ return '''/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+'''
+
+def get_build_gradle(description):
+ return dedent('''apply plugin: 'java-library'
+
+description = '%s'
+
+configurations.all {
Review comment:
Pushed a fix, removing these exclusions.
Reason I put them in there was when I did #518 I had added zookeeper as implementation dep, while it should be a testImplementation dep. Fixed that now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on a change in pull request #519: Script to scaffold a new contrib module
Posted by GitBox <gi...@apache.org>.
janhoy commented on a change in pull request #519:
URL: https://github.com/apache/solr/pull/519#discussion_r783085882
##########
File path: dev-tools/scripts/addContrib.py
##########
@@ -0,0 +1,170 @@
+#!/usr/bin/env python3
+# -*- coding: utf-8 -*-
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+import os
+import sys
+sys.path.append(os.path.dirname(__file__))
+from scriptutil import *
+
+import argparse
+import re
+from textwrap import dedent
+
+def update_build(file_path, search_re, replace_line):
+ print('adding contrib into %s' % file_path)
+ matcher = re.compile(search_re)
+
+ def edit(buffer, match, line):
+ if replace_line in line:
+ return None
+ match = matcher.search(line)
+ if match is not None:
+ buffer.append(replace_line)
+ buffer.append(line)
+ return match is not None
+
+ changed = update_file(file_path, matcher, edit)
+ print('done' if changed else 'uptodate')
+
+
+def read_config():
+ parser = argparse.ArgumentParser(description='Scaffold new contrib module')
+ parser.add_argument("name")
+ parser.add_argument("full_name")
+ parser.add_argument("description")
+ newconf = parser.parse_args()
+ return newconf
+
+
+def get_readme_skel(conrib_name):
+ return dedent('''Apache Solr %s
+=====================================
+
+Introduction
+------------
+TBD
+
+Getting Started
+---------------
+TBD
+''' % conrib_name)
+
+def get_license_header():
+ return '''/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+'''
+
+def get_build_gradle(description):
+ return dedent('''apply plugin: 'java-library'
+
+description = '%s'
+
+configurations.all {
Review comment:
Will try to remove it from `jwt-auth` contrib and see how else I can get rid of those jars..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dweiss commented on a change in pull request #519: Script to scaffold a new contrib module
Posted by GitBox <gi...@apache.org>.
dweiss commented on a change in pull request #519:
URL: https://github.com/apache/solr/pull/519#discussion_r783013875
##########
File path: dev-tools/scripts/addContrib.py
##########
@@ -0,0 +1,170 @@
+#!/usr/bin/env python3
+# -*- coding: utf-8 -*-
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+import os
+import sys
+sys.path.append(os.path.dirname(__file__))
+from scriptutil import *
+
+import argparse
+import re
+from textwrap import dedent
+
+def update_build(file_path, search_re, replace_line):
+ print('adding contrib into %s' % file_path)
+ matcher = re.compile(search_re)
+
+ def edit(buffer, match, line):
+ if replace_line in line:
+ return None
+ match = matcher.search(line)
+ if match is not None:
+ buffer.append(replace_line)
+ buffer.append(line)
+ return match is not None
+
+ changed = update_file(file_path, matcher, edit)
+ print('done' if changed else 'uptodate')
+
+
+def read_config():
+ parser = argparse.ArgumentParser(description='Scaffold new contrib module')
+ parser.add_argument("name")
+ parser.add_argument("full_name")
+ parser.add_argument("description")
+ newconf = parser.parse_args()
+ return newconf
+
+
+def get_readme_skel(conrib_name):
+ return dedent('''Apache Solr %s
+=====================================
+
+Introduction
+------------
+TBD
+
+Getting Started
+---------------
+TBD
+''' % conrib_name)
+
+def get_license_header():
+ return '''/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+'''
+
+def get_build_gradle(description):
+ return dedent('''apply plugin: 'java-library'
+
+description = '%s'
+
+configurations.all {
Review comment:
You shouldn't need this or do this. This is wrong. It's not a configuration that should exclude dependencies - it's either a dependency that should exclude it or a configuration this dependency is attached to should make it optional (compileOnly, runtimeOnly).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dweiss commented on a change in pull request #519: Script to scaffold a new contrib module
Posted by GitBox <gi...@apache.org>.
dweiss commented on a change in pull request #519:
URL: https://github.com/apache/solr/pull/519#discussion_r783121786
##########
File path: dev-tools/scripts/addContrib.py
##########
@@ -0,0 +1,170 @@
+#!/usr/bin/env python3
+# -*- coding: utf-8 -*-
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+import os
+import sys
+sys.path.append(os.path.dirname(__file__))
+from scriptutil import *
+
+import argparse
+import re
+from textwrap import dedent
+
+def update_build(file_path, search_re, replace_line):
+ print('adding contrib into %s' % file_path)
+ matcher = re.compile(search_re)
+
+ def edit(buffer, match, line):
+ if replace_line in line:
+ return None
+ match = matcher.search(line)
+ if match is not None:
+ buffer.append(replace_line)
+ buffer.append(line)
+ return match is not None
+
+ changed = update_file(file_path, matcher, edit)
+ print('done' if changed else 'uptodate')
+
+
+def read_config():
+ parser = argparse.ArgumentParser(description='Scaffold new contrib module')
+ parser.add_argument("name")
+ parser.add_argument("full_name")
+ parser.add_argument("description")
+ newconf = parser.parse_args()
+ return newconf
+
+
+def get_readme_skel(conrib_name):
+ return dedent('''Apache Solr %s
+=====================================
+
+Introduction
+------------
+TBD
+
+Getting Started
+---------------
+TBD
+''' % conrib_name)
+
+def get_license_header():
+ return '''/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+'''
+
+def get_build_gradle(description):
+ return dedent('''apply plugin: 'java-library'
+
+description = '%s'
+
+configurations.all {
Review comment:
The least you can do is apply this closure not to all configurations but only to those that originate from the java plugin -
https://docs.gradle.org/current/userguide/java_library_plugin.html#sec:java_library_configurations_graph
Configurations are a very broad concept and are used all around the place (including plugins) - excluding arbitrary dependencies from everything is asking for trouble.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #519: Script to scaffold a new contrib module
Posted by GitBox <gi...@apache.org>.
janhoy commented on pull request #519:
URL: https://github.com/apache/solr/pull/519#issuecomment-1013205291
I'm a Python ninja™ so this was a breeze 😁 I did it because the time I spent figuring out how to wire in a new contrib into the build was more than I spend moving the classes from core to the new module. And the very presence of a scaffold script in git will perhaps lower the bar for others to quickly lift out some functionality as a package. I can easily see a dozen more packages materializing. So if I put in 2 hours making the script, and save 12 hours of other's time fiddling with the build that's net 10 hours saved :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley commented on pull request #519: Script to scaffold a new contrib module
Posted by GitBox <gi...@apache.org>.
dsmiley commented on pull request #519:
URL: https://github.com/apache/solr/pull/519#issuecomment-1012478398
I think it's awesome there is so much energy in modularizing Solr now! Though I don't think the particular task that this script does was a good investment of you or anyone's time. It does something rather trivial and naturally is just an initial step, and furthermore we won't run this script more than a handful of times. But hey, you put in the work so +1 if you wish to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on a change in pull request #519: Script to scaffold a new contrib module
Posted by GitBox <gi...@apache.org>.
janhoy commented on a change in pull request #519:
URL: https://github.com/apache/solr/pull/519#discussion_r783149106
##########
File path: dev-tools/scripts/addContrib.py
##########
@@ -0,0 +1,170 @@
+#!/usr/bin/env python3
+# -*- coding: utf-8 -*-
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+import os
+import sys
+sys.path.append(os.path.dirname(__file__))
+from scriptutil import *
+
+import argparse
+import re
+from textwrap import dedent
+
+def update_build(file_path, search_re, replace_line):
+ print('adding contrib into %s' % file_path)
+ matcher = re.compile(search_re)
+
+ def edit(buffer, match, line):
+ if replace_line in line:
+ return None
+ match = matcher.search(line)
+ if match is not None:
+ buffer.append(replace_line)
+ buffer.append(line)
+ return match is not None
+
+ changed = update_file(file_path, matcher, edit)
+ print('done' if changed else 'uptodate')
+
+
+def read_config():
+ parser = argparse.ArgumentParser(description='Scaffold new contrib module')
+ parser.add_argument("name")
+ parser.add_argument("full_name")
+ parser.add_argument("description")
+ newconf = parser.parse_args()
+ return newconf
+
+
+def get_readme_skel(conrib_name):
+ return dedent('''Apache Solr %s
+=====================================
+
+Introduction
+------------
+TBD
+
+Getting Started
+---------------
+TBD
+''' % conrib_name)
+
+def get_license_header():
+ return '''/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+'''
+
+def get_build_gradle(description):
+ return dedent('''apply plugin: 'java-library'
+
+description = '%s'
+
+configurations.all {
Review comment:
Do you have an opinion on this: https://github.com/apache/solr/pull/518#discussion_r782898576 ? I.e. should slf4j-api in solr-core be `api` or `implementation`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org