You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/04/24 15:53:11 UTC

[GitHub] [camel-k] nicolaferraro opened a new issue #1428: Use /openapi.json as default location for OpenAPI data

nicolaferraro opened a new issue #1428:
URL: https://github.com/apache/camel-k/issues/1428


   This applies to the 3scale trait, which currently uses `/api-doc` by default.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] rajatdiptabiswas commented on issue #1428: Use /openapi.json as default location for OpenAPI data

Posted by GitBox <gi...@apache.org>.
rajatdiptabiswas commented on issue #1428:
URL: https://github.com/apache/camel-k/issues/1428#issuecomment-619101918


   Would you kindly let me know what exactly needs to be done so that I can try working on it?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] nicolaferraro commented on issue #1428: Use /openapi.json as default location for OpenAPI data

Posted by GitBox <gi...@apache.org>.
nicolaferraro commented on issue #1428:
URL: https://github.com/apache/camel-k/issues/1428#issuecomment-621752940


   Yes, changing that variable plus the mention is ok.
   
   traits.yaml, and 3scale.adoc can be manually changed or auto-updated running `make generate-doc`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] rajatdiptabiswas edited a comment on issue #1428: Use /openapi.json as default location for OpenAPI data

Posted by GitBox <gi...@apache.org>.
rajatdiptabiswas edited a comment on issue #1428:
URL: https://github.com/apache/camel-k/issues/1428#issuecomment-621341382


   Hi @nicolaferraro!
   
   From what I understood, I believe I should change `ThreeScaleDescriptionPathDefaultValue = "/api-doc"` to `ThreeScaleDescriptionPathDefaultValue = "/openapi.json"` in line 67 of `/addons/threescale/3scale.go`
   
   There are a few more mentions of `/api-doc` in `3scale_test.go`, `traits.yaml`, and `3scale.adoc`.  One more in line 44 of `3scale.go` as well. 
   Do I need to make any changes to those?
   
   I am hopeful I shall be able to make the required changes. 
   Kindly confirm if I have understood your instructions correctly.
   
   Thanks in advance!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] nicolaferraro commented on issue #1428: Use /openapi.json as default location for OpenAPI data

Posted by GitBox <gi...@apache.org>.
nicolaferraro commented on issue #1428:
URL: https://github.com/apache/camel-k/issues/1428#issuecomment-621238638


   Hi @rajatdiptabiswas, I think it's sufficient to change the default value in the threescale addon trait from "/api-doc" to "/openapi.json". Can you do it?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] rajatdiptabiswas commented on issue #1428: Use /openapi.json as default location for OpenAPI data

Posted by GitBox <gi...@apache.org>.
rajatdiptabiswas commented on issue #1428:
URL: https://github.com/apache/camel-k/issues/1428#issuecomment-621341382


   From what I understood, I believe I should change `ThreeScaleDescriptionPathDefaultValue = "/api-doc"` to `ThreeScaleDescriptionPathDefaultValue = "/openapi.json"` in line 67 of `/addons/threescale/3scale.go`
   
   There are a few more mentions of `/api-doc` in `3scale_test.go`, `traits.yaml`, and `3scale.adoc`.  One more in line 44 of `3scale.go` as well. 
   Do I need to make any changes to those?
   
   I am hopeful I shall be able to make the required changes. 
   Kindly confirm if I have understood your instructions correctly.
   
   Thanks in advance!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org