You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by PetroKostyuk <gi...@git.apache.org> on 2016/12/19 18:32:37 UTC
[GitHub] zeppelin pull request #1783: Zeppelin 727
GitHub user PetroKostyuk opened a pull request:
https://github.com/apache/zeppelin/pull/1783
Zeppelin 727
### What is this PR for?
This PR adds button that allows user to copy link to paragraph in context. Then if user follows this link, it will load note and scroll to selected paragraph
### What type of PR is it?
Feature
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-727
### How should this be tested?
1) Open note, choose one paragraph and click on 'Link to paragrapgh in context'.
2) Copy link that is prompted to you.
3) Open link in new tab or window.
4) Your notebook should load and scroll to linked paragraph.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PetroKostyuk/zeppelin ZEPPELIN-727
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1783.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1783
----
commit 5f121c6efae6b2cc1c9998594aca9e6377da6850
Author: Petro Kostyuk <ko...@fel.cvut.cz>
Date: 2016-12-19T18:19:18Z
ZEPPELIN-727
commit 43229045c37a7062bec3549e15f8a426bf9af3b5
Author: Petro Kostyuk <ko...@fel.cvut.cz>
Date: 2016-12-19T18:23:53Z
typo
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1783: Zeppelin 727
Posted by aurely06 <gi...@git.apache.org>.
Github user aurely06 commented on the issue:
https://github.com/apache/zeppelin/pull/1783
Hi,
Any update about this request ? The link to paragraph in context is available or not yet ?
Thank you !
---
[GitHub] zeppelin issue #1783: Zeppelin 727
Posted by aurely06 <gi...@git.apache.org>.
Github user aurely06 commented on the issue:
https://github.com/apache/zeppelin/pull/1783
ok, thank you for your answser
---
[GitHub] zeppelin issue #1783: Zeppelin 727
Posted by FireArrow <gi...@git.apache.org>.
Github user FireArrow commented on the issue:
https://github.com/apache/zeppelin/pull/1783
I agree with @AhyoungRyu. What she describes is the common way to link to paragraphs, so it seems reasonable to assume that is what users are used to.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1783: Zeppelin 727
Posted by PetroKostyuk <gi...@git.apache.org>.
Github user PetroKostyuk commented on the issue:
https://github.com/apache/zeppelin/pull/1783
As it seems, this pull request is still open, so this feature is not in added to application. I no longer work on zeppelin project, so I don't know whether this feature will get published in future or no.
---
[GitHub] zeppelin issue #1783: Zeppelin 727
Posted by PetroKostyuk <gi...@git.apache.org>.
Github user PetroKostyuk commented on the issue:
https://github.com/apache/zeppelin/pull/1783
Thank you for your replays!
I'll try to implement what you suggested, it will indeed make this feature more user friendly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1783: Zeppelin 727
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1783
---
[GitHub] zeppelin issue #1783: Zeppelin 727
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1783
@PetroKostyuk Thanks for your contribution! It's really useful feature indeed.
For the quick review, it would be better to edit PR title to sth like "[ZEPPELIN-727] Enable to jump to specific paragraph using anchor" instead of just "ZEPPELIN 727". Then other ppl can recognize what this PR implemented at a glance.
I tested and it works well as you described. Here are some my thoughts
1. In my case, couldn't get the difference between 
and  at the first time. Probably some users will be same with me. I know "Link this paragraph" is existed one, but "Publish this paragraph with iframe" instead of "Link this paragraph" would be more precise to prevent any confusion.
2. With this PR, we need to
Click gear icon -> Click "Link to paragraph in context" menu -> Ctrl+C and enter to copy the paragraph url -> Open new tab -> Paste the url
IMPO using anchor has to be simple. Let's say we need specific paragraph url to give this location to someone. e.g. in Zeppelin official docs site,
The icon is exposed in the outside(need mouse hovering) and we can instinctively recognize what it is.
So i think it would be better the anchor icon can be exposed in the outside not in the dropdown menu. And after we click that icon, the url will be exposed in the top header bar like I posted in the above, or maybe automatically copied right after we click it (please refer to #1750 ).
It's just my opinion in my head. So please take with grain of salt and feel free to share your thought! :D
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---