You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "bziobrowski (via GitHub)" <gi...@apache.org> on 2024/10/11 07:45:39 UTC

[PR] Speedup dev build. [pinot]

bziobrowski opened a new pull request, #14210:
URL: https://github.com/apache/pinot/pull/14210

   This PR speeds up developer build (one with pinot-fastdev profile enabled) by skipping compression and e.g. npm validation.
   Following build command on my desktop :
   `mvn -DskipTests=true --also-make   --projects pinot-distribution package -P'pinot-fastdev,bin-dist' -T1C`
   takes:
   in master branch - 3 minutes 
   in this branch - 2 minutes. 
   It looks possible to shave another 30 seconds by disabling compression in shade plugin but that'd require changing plugin code.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [PR] Speedup dev build. [pinot]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #14210:
URL: https://github.com/apache/pinot/pull/14210#issuecomment-2406887901

   ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14210?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Project coverage is 0.00%. Comparing base [(`59551e4`)](https://app.codecov.io/gh/apache/pinot/commit/59551e45224f1535c4863fd577622b37366ccc97?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`badd7b0`)](https://app.codecov.io/gh/apache/pinot/commit/badd7b06f70f16805cab6a127030607a431bf7b1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   > Report is 1176 commits behind head on master.
   
   > :exclamation:  There is a different number of reports uploaded between BASE (59551e4) and HEAD (badd7b0). Click for more details.
   > 
   > <details><summary>HEAD has 53 uploads less than BASE</summary>
   >
   >| Flag | BASE (59551e4) | HEAD (badd7b0) |
   >|------|------|------|
   >|integration|7|1|
   >|integration2|3|1|
   >|temurin|12|1|
   >|java-21|7|1|
   >|skip-bytebuffers-true|3|1|
   >|skip-bytebuffers-false|7|0|
   >|unittests|5|0|
   >|unittests1|2|0|
   >|java-11|5|0|
   >|unittests2|3|0|
   >|integration1|2|0|
   >|custom-integration1|2|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #14210       +/-   ##
   =============================================
   - Coverage     61.75%    0.00%   -61.76%     
   =============================================
     Files          2436        3     -2433     
     Lines        133233        6   -133227     
     Branches      20636        0    -20636     
   =============================================
   - Hits          82274        0    -82274     
   + Misses        44911        6    -44905     
   + Partials       6048        0     -6048     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/pinot/pull/14210/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [custom-integration1](https://app.codecov.io/gh/apache/pinot/pull/14210/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [integration](https://app.codecov.io/gh/apache/pinot/pull/14210/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (-0.01%)` | :arrow_down: |
   | [integration1](https://app.codecov.io/gh/apache/pinot/pull/14210/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [integration2](https://app.codecov.io/gh/apache/pinot/pull/14210/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | |
   | [java-11](https://app.codecov.io/gh/apache/pinot/pull/14210/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [java-21](https://app.codecov.io/gh/apache/pinot/pull/14210/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (-61.63%)` | :arrow_down: |
   | [skip-bytebuffers-false](https://app.codecov.io/gh/apache/pinot/pull/14210/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [skip-bytebuffers-true](https://app.codecov.io/gh/apache/pinot/pull/14210/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (-27.73%)` | :arrow_down: |
   | [temurin](https://app.codecov.io/gh/apache/pinot/pull/14210/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (-61.76%)` | :arrow_down: |
   | [unittests](https://app.codecov.io/gh/apache/pinot/pull/14210/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [unittests1](https://app.codecov.io/gh/apache/pinot/pull/14210/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [unittests2](https://app.codecov.io/gh/apache/pinot/pull/14210/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/pinot/pull/14210?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [PR] Speed up dev build. [pinot]

Posted by "bziobrowski (via GitHub)" <gi...@apache.org>.
bziobrowski commented on code in PR #14210:
URL: https://github.com/apache/pinot/pull/14210#discussion_r1803496921


##########
pinot-controller/src/main/resources/package.json:
##########
@@ -57,7 +57,8 @@
     "url-loader": "4.1.1",
     "webpack": "4.29.6",
     "webpack-cli": "3.3.0",
-    "webpack-dev-server": "3.2.1"
+    "webpack-dev-server": "3.2.1",
+    "hard-source-webpack-plugin": "0.13.1"

Review Comment:
   It was meant to speed up webpack build via caching but I've reverted it .



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [PR] Speed up dev build. [pinot]

Posted by "gortiz (via GitHub)" <gi...@apache.org>.
gortiz merged PR #14210:
URL: https://github.com/apache/pinot/pull/14210


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [PR] Speed up dev build. [pinot]

Posted by "gortiz (via GitHub)" <gi...@apache.org>.
gortiz commented on code in PR #14210:
URL: https://github.com/apache/pinot/pull/14210#discussion_r1806502862


##########
pinot-controller/pom.xml:
##########
@@ -166,5 +167,41 @@
         <npm.script>build</npm.script>
       </properties>
     </profile>
+    <profile>
+      <id>pinot-fastdev</id>
+      <build>
+        <plugins>
+          <plugin>
+            <groupId>org.codehaus.mojo</groupId>
+            <artifactId>build-helper-maven-plugin</artifactId>
+            <version>3.6.0</version>
+            <executions>
+              <execution>
+                <id>check-frontend-up-to-date</id>
+                <phase>process-sources</phase>
+                <goals>
+                  <goal>uptodate-property</goal>
+                </goals>
+                <configuration>

Review Comment:
   I didn't know this plugin, it could be also useful in pinot-commons!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [PR] Speed up dev build. [pinot]

Posted by "bziobrowski (via GitHub)" <gi...@apache.org>.
bziobrowski commented on code in PR #14210:
URL: https://github.com/apache/pinot/pull/14210#discussion_r1807473107


##########
pinot-controller/pom.xml:
##########
@@ -166,5 +167,41 @@
         <npm.script>build</npm.script>
       </properties>
     </profile>
+    <profile>
+      <id>pinot-fastdev</id>
+      <build>
+        <plugins>
+          <plugin>
+            <groupId>org.codehaus.mojo</groupId>
+            <artifactId>build-helper-maven-plugin</artifactId>
+            <version>3.6.0</version>
+            <executions>
+              <execution>
+                <id>check-frontend-up-to-date</id>
+                <phase>process-sources</phase>
+                <goals>
+                  <goal>uptodate-property</goal>
+                </goals>
+                <configuration>

Review Comment:
   This approach, while useful, isn't bulletproof. 
   If one switches between branches then it won't trigger build if files in current branch are older than in the previous one. 
   Still, it's better than checking whether target file exists. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [PR] Speedup dev build. [pinot]

Posted by "gortiz (via GitHub)" <gi...@apache.org>.
gortiz commented on code in PR #14210:
URL: https://github.com/apache/pinot/pull/14210#discussion_r1796787011


##########
pinot-controller/pom.xml:
##########
@@ -121,13 +122,13 @@
             </configuration>
           </execution>
           <execution>
-            <id>npm ci</id>
+            <id>npm ci</id><!-- npm ci removes node_modules! -->

Review Comment:
   IIRC npm install actually modifies `package.json` in order to install new versions of the libraries, which is something we don't want.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [PR] Speed up dev build. [pinot]

Posted by "bziobrowski (via GitHub)" <gi...@apache.org>.
bziobrowski commented on code in PR #14210:
URL: https://github.com/apache/pinot/pull/14210#discussion_r1807473744


##########
pom.xml:
##########
@@ -294,6 +296,9 @@
         <rat.skip>true</rat.skip>
         <spotless.check.skip>true</spotless.check.skip>
         <shade.phase.prop>none</shade.phase.prop>
+        <archiver.compress>false</archiver.compress>
+        <archiver.recompressZippedFiles>false</archiver.recompressZippedFiles>
+        <npm.command>install --no-audit</npm.command>

Review Comment:
   Yes, npm.command is not used anymore. 
   In theory it should be possible to limit or turn off potential dependency updates of `npm install` but I don't think there's any guarantee. I used `npm install --no-audit` earlier because it takes about 1s vs ~10s taken by `npm ci`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [PR] Speed up dev build. [pinot]

Posted by "vrajat (via GitHub)" <gi...@apache.org>.
vrajat commented on code in PR #14210:
URL: https://github.com/apache/pinot/pull/14210#discussion_r1800927019


##########
pinot-controller/src/main/resources/package.json:
##########
@@ -57,7 +57,8 @@
     "url-loader": "4.1.1",
     "webpack": "4.29.6",
     "webpack-cli": "3.3.0",
-    "webpack-dev-server": "3.2.1"
+    "webpack-dev-server": "3.2.1",
+    "hard-source-webpack-plugin": "0.13.1"

Review Comment:
   What functionality does this package provide ? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [PR] Speed up dev build. [pinot]

Posted by "bziobrowski (via GitHub)" <gi...@apache.org>.
bziobrowski commented on code in PR #14210:
URL: https://github.com/apache/pinot/pull/14210#discussion_r1801373445


##########
pinot-controller/pom.xml:
##########
@@ -121,13 +122,13 @@
             </configuration>
           </execution>
           <execution>
-            <id>npm ci</id>
+            <id>npm ci</id><!-- npm ci removes node_modules! -->

Review Comment:
   You're right. Let me check if we can get an even better speedup (and matching behavior) by switching to another package manager (current one is horribly slow).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [PR] Speed up dev build. [pinot]

Posted by "gortiz (via GitHub)" <gi...@apache.org>.
gortiz commented on code in PR #14210:
URL: https://github.com/apache/pinot/pull/14210#discussion_r1806501164


##########
pinot-controller/pom.xml:
##########
@@ -32,6 +32,7 @@
   <properties>
     <pinot.root>${basedir}/..</pinot.root>
     <npm.script>build-ci</npm.script>
+    <npm.command>ci</npm.command>

Review Comment:
   this isn't needed, right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [PR] Speed up dev build. [pinot]

Posted by "bziobrowski (via GitHub)" <gi...@apache.org>.
bziobrowski commented on code in PR #14210:
URL: https://github.com/apache/pinot/pull/14210#discussion_r1803496298


##########
pinot-controller/pom.xml:
##########
@@ -121,13 +122,13 @@
             </configuration>
           </execution>
           <execution>
-            <id>npm ci</id>
+            <id>npm ci</id><!-- npm ci removes node_modules! -->

Review Comment:
   I reverted the change and added up-to-date check between source js files and main.js, executed only for pinot-fastdev profile.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [PR] Speed up dev build. [pinot]

Posted by "gortiz (via GitHub)" <gi...@apache.org>.
gortiz commented on code in PR #14210:
URL: https://github.com/apache/pinot/pull/14210#discussion_r1806508454


##########
pom.xml:
##########
@@ -294,6 +296,9 @@
         <rat.skip>true</rat.skip>
         <spotless.check.skip>true</spotless.check.skip>
         <shade.phase.prop>none</shade.phase.prop>
+        <archiver.compress>false</archiver.compress>
+        <archiver.recompressZippedFiles>false</archiver.recompressZippedFiles>
+        <npm.command>install --no-audit</npm.command>

Review Comment:
   I don't think we should run `install` by default. It is unsafe to update dependencies. And with the usage of build-helper:uptodate-property it shouldn't be problematic if pinot-fastdev profile is enabled, am I right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [PR] Speed up dev build. [pinot]

Posted by "bziobrowski (via GitHub)" <gi...@apache.org>.
bziobrowski commented on code in PR #14210:
URL: https://github.com/apache/pinot/pull/14210#discussion_r1807471760


##########
pinot-controller/pom.xml:
##########
@@ -32,6 +32,7 @@
   <properties>
     <pinot.root>${basedir}/..</pinot.root>
     <npm.script>build-ci</npm.script>
+    <npm.command>ci</npm.command>

Review Comment:
   Yep, removed in latest commit.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [PR] Speed up dev build. [pinot]

Posted by "gortiz (via GitHub)" <gi...@apache.org>.
gortiz commented on code in PR #14210:
URL: https://github.com/apache/pinot/pull/14210#discussion_r1806502011


##########
pinot-controller/pom.xml:
##########
@@ -121,7 +122,7 @@
             </configuration>
           </execution>
           <execution>
-            <id>npm ci</id>
+            <id>npm ci</id><!-- npm ci removes node_modules! -->

Review Comment:
   I have the feeling this comment is a bit strange now that we are actually running ci



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [PR] Speed up dev build. [pinot]

Posted by "bziobrowski (via GitHub)" <gi...@apache.org>.
bziobrowski commented on code in PR #14210:
URL: https://github.com/apache/pinot/pull/14210#discussion_r1807471796


##########
pinot-controller/pom.xml:
##########
@@ -121,7 +122,7 @@
             </configuration>
           </execution>
           <execution>
-            <id>npm ci</id>
+            <id>npm ci</id><!-- npm ci removes node_modules! -->

Review Comment:
   Removed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [PR] Speed up dev build. [pinot]

Posted by "gortiz (via GitHub)" <gi...@apache.org>.
gortiz commented on code in PR #14210:
URL: https://github.com/apache/pinot/pull/14210#discussion_r1812558025


##########
README.md:
##########
@@ -95,10 +95,15 @@ SELECT sum(clicks), sum(impressions) FROM AdAnalyticsTable
 
 ## Contributing to Pinot
 
-Normal Pinot builds are done using the `mvn clean install` command. 
-However this command can take a long time to run.
-For faster builds it is recommended to use `mvn verify -Ppinot-fastdev`, which disables some plugins that are not 
-actually needed for development and disables artifact compression. 
+Want to contribute to apache/pinot? 👋🍷
+
+Want to join the ranks of open source committers to Apache Pinot? Then check out the [Contribution Guide](https://docs.pinot.apache.org/developers/developers-and-contributors/contribution-guidelines) for how you can get involved in the code.
+
+If you have a bug or an idea for a new feature, browse the [open issues](https://github.com/apache/pinot/issues) to see what we’re already working on before opening a new one.
+
+We also tagged some [beginner issues](https://github.com/apache/pinot/issues?q=is%3Aopen+is%3Aissue+label%3Abeginner-task) new contributors can tackle.
+
+

Review Comment:
   Oh! It was changed in master, not here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [PR] Speed up dev build. [pinot]

Posted by "gortiz (via GitHub)" <gi...@apache.org>.
gortiz commented on code in PR #14210:
URL: https://github.com/apache/pinot/pull/14210#discussion_r1812553017


##########
README.md:
##########
@@ -95,10 +95,15 @@ SELECT sum(clicks), sum(impressions) FROM AdAnalyticsTable
 
 ## Contributing to Pinot
 
-Normal Pinot builds are done using the `mvn clean install` command. 
-However this command can take a long time to run.
-For faster builds it is recommended to use `mvn verify -Ppinot-fastdev`, which disables some plugins that are not 
-actually needed for development and disables artifact compression. 
+Want to contribute to apache/pinot? 👋🍷
+
+Want to join the ranks of open source committers to Apache Pinot? Then check out the [Contribution Guide](https://docs.pinot.apache.org/developers/developers-and-contributors/contribution-guidelines) for how you can get involved in the code.
+
+If you have a bug or an idea for a new feature, browse the [open issues](https://github.com/apache/pinot/issues) to see what we’re already working on before opening a new one.
+
+We also tagged some [beginner issues](https://github.com/apache/pinot/issues?q=is%3Aopen+is%3Aissue+label%3Abeginner-task) new contributors can tackle.
+
+

Review Comment:
   Where are we going to suggest to use the `pinot-fastdev` profile now?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org