Re: Review Request 43622: Updating scheduler backup restore instructions.

[Maxim Khutornenko <ma...@apache.org>]

> On Feb. 23, 2016, 4:44 p.m., Stephan Erb wrote:
> > docs/storage-config.md, line 99
> > <https://reviews.apache.org/r/43622/diff/3/?file=1252169#file1252169line99>
> >
> >     I'd propose to move this section after the point "Identify the leading scheduler". Only at that point it is clear what what scheduler URL to put there.
> >     
> >     Slight nitpick: the sentence is difficult to read due to the duplicate `aurora_admin`. One of those can be dropped.

I'd rather keep it here as preparation steps may require scheduler restart, which will likely change the leader. I've added a sentence suggesting changes on all replicas though. This way all preparation steps could easily get automated (this is in fact how we do things internally).


> On Feb. 23, 2016, 4:44 p.m., Stephan Erb wrote:
> > docs/storage-config.md, line 101
> > <https://reviews.apache.org/r/43622/diff/3/?file=1252169#file1252169line101>
> >
> >     There is a small bug in the referenced documentation snippet. The `scheduler_url` must contain the schema (`http://`) otherwise `aurora_admin scheduler_stage_recovery` won't work.

Thanks for pointing out. Fixed.


> On Feb. 23, 2016, 4:44 p.m., Stephan Erb wrote:
> > docs/storage-config.md, line 103
> > <https://reviews.apache.org/r/43622/diff/3/?file=1252169#file1252169line103>
> >
> >     Addition regarding my first statement: This sub-section probably does not need to be moved. In can be kept in the preperation section.

I'd rather keep preparation steps together to logically distiguish potentially automatable prep steps from manual restore actions.


> On Feb. 23, 2016, 4:44 p.m., Stephan Erb wrote:
> > docs/storage-config.md, line 121
> > <https://reviews.apache.org/r/43622/diff/3/?file=1252169#file1252169line121>
> >
> >     I think we might leave thos one out. Does not seem necessary.

This was supposed to be start not restart. Fixed.


> On Feb. 23, 2016, 4:44 p.m., Stephan Erb wrote:
> > docs/storage-config.md, line 143
> > <https://reviews.apache.org/r/43622/diff/3/?file=1252169#file1252169line143>
> >
> >     Two important points are missing here:
> >     
> >     * has to be copied into the db backup folder
> >     * the `scheduler-backup...` is the file name and not a path

> has to be copied into the db backup folder

Thanks, clarified.

> the scheduler-backup... is the file name and not a path

I thought that's obvious from the command example listed below, no?


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43622/#review120329
-----------------------------------------------------------


On Feb. 16, 2016, 11:10 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43622/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2016, 11:10 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Stephan Erb.
> 
> 
> Bugs: AURORA-1605
>     https://issues.apache.org/jira/browse/AURORA-1605
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Updating scheduler backup restore instructions.
> 
> 
> Diffs
> -----
> 
>   docs/storage-config.md c838ea3291bf21428d8dcb0be53651ca4ceb5dda 
>   docs/thrift-deprecation.md e1f1fbcfb119efa6b015d548266386a1486d932b 
> 
> Diff: https://reviews.apache.org/r/43622/diff/
> 
> 
> Testing
> -------
> 
> https://github.com/maxim111333/incubator-aurora/blob/backup_restore_instructions/docs/storage-config.md#recovering-from-a-scheduler-backup
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>