You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Madhan Neethiraj <ma...@apache.org> on 2020/02/15 02:11:17 UTC
Review Request 72137: ATLAS-3621: updated HiveHook to not save
query-string in multiple attributes - queryText and name
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72137/
-----------------------------------------------------------
Review request for atlas, Ashutosh Mestry, Mandar Ambawane, mayank jain, Mehul Parikh, Nixon Rodrigues, Pinal Shah, Sarath Subramanian, and Sidharth Mishra.
Bugs: ATLAS-3621
https://issues.apache.org/jira/browse/ATLAS-3621
Repository: atlas
Description
-------
- updated HiveHook to set hive_process.name and hive_column_lineage.name to the value in qualifiedName (instead of the query-string)
- updated NotificationHookConsumer to update these attributes similarly, to handle notifications that were generated by earlier hook
Diffs
-----
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java 0409d8ae0
webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java 14cae4228
webapp/src/main/java/org/apache/atlas/notification/preprocessor/HivePreprocessor.java cc5fe5221
webapp/src/main/java/org/apache/atlas/notification/preprocessor/PreprocessorContext.java 3c58c9fce
Diff: https://reviews.apache.org/r/72137/diff/1/
Testing
-------
- verified that attribute 'name' in hive_process and hive_column_lineage are set to the value in qualifiedName, instead of query-string, by executing a hive query
- precommit tests run: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1637
Thanks,
Madhan Neethiraj
Re: Review Request 72137: ATLAS-3621: updated HiveHook to not save
query-string in multiple attributes - queryText and name
Posted by Nixon Rodrigues <ni...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72137/#review219594
-----------------------------------------------------------
Ship it!
Ship It!
- Nixon Rodrigues
On Feb. 15, 2020, 2:11 a.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72137/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2020, 2:11 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Mandar Ambawane, mayank jain, Mehul Parikh, Nixon Rodrigues, Pinal Shah, Sarath Subramanian, and Sidharth Mishra.
>
>
> Bugs: ATLAS-3621
> https://issues.apache.org/jira/browse/ATLAS-3621
>
>
> Repository: atlas
>
>
> Description
> -------
>
> - updated HiveHook to set hive_process.name and hive_column_lineage.name to the value in qualifiedName (instead of the query-string)
> - updated NotificationHookConsumer to update these attributes similarly, to handle notifications that were generated by earlier hook
>
>
> Diffs
> -----
>
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java 0409d8ae0
> webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java 14cae4228
> webapp/src/main/java/org/apache/atlas/notification/preprocessor/HivePreprocessor.java cc5fe5221
> webapp/src/main/java/org/apache/atlas/notification/preprocessor/PreprocessorContext.java 3c58c9fce
>
>
> Diff: https://reviews.apache.org/r/72137/diff/1/
>
>
> Testing
> -------
>
> - verified that attribute 'name' in hive_process and hive_column_lineage are set to the value in qualifiedName, instead of query-string, by executing a hive query
> - precommit tests run: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1637
>
>
> Thanks,
>
> Madhan Neethiraj
>
>