You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@avro.apache.org by mg...@apache.org on 2022/02/02 19:06:50 UTC
[avro] branch branch-1.11 updated: AVRO-3352: Only Newtonsoft uses minimum version as of now (#1503)
This is an automated email from the ASF dual-hosted git repository.
mgrigorov pushed a commit to branch branch-1.11
in repository https://gitbox.apache.org/repos/asf/avro.git
The following commit(s) were added to refs/heads/branch-1.11 by this push:
new 756c79d AVRO-3352: Only Newtonsoft uses minimum version as of now (#1503)
756c79d is described below
commit 756c79d889b1411d783ed2a4014e94dbe5493edd
Author: Zoltan Csizmadia <zc...@gmail.com>
AuthorDate: Wed Feb 2 13:06:02 2022 -0600
AVRO-3352: Only Newtonsoft uses minimum version as of now (#1503)
* AVRO-3352: Only Newtonsoft uses minimum version as of now
* AVRO-3352: Remove unused PackageReferences
* AVRO-3352: Remove unwanted test console output
Co-authored-by: Zoltan Csizmadia <Cs...@valassis.com>
(cherry picked from commit 0cd0aa1f198e16c94cce03f7742f235d2d5bb4bd)
---
lang/csharp/src/apache/main/Avro.main.csproj | 5 +----
lang/csharp/src/apache/test/Avro.test.csproj | 1 -
lang/csharp/src/apache/test/Schema/AliasTest.cs | 3 +--
lang/csharp/versions.props | 19 ++++++++-----------
4 files changed, 10 insertions(+), 18 deletions(-)
diff --git a/lang/csharp/src/apache/main/Avro.main.csproj b/lang/csharp/src/apache/main/Avro.main.csproj
index 7ec0949..beb1dff 100644
--- a/lang/csharp/src/apache/main/Avro.main.csproj
+++ b/lang/csharp/src/apache/main/Avro.main.csproj
@@ -50,10 +50,7 @@
<!-- See lang/csharp/README.md for tool and library dependency update strategy -->
<ItemGroup>
<PackageReference Include="Newtonsoft.Json" Version="$(NewtonsoftJsonMinimumVersion)" />
- <PackageReference Include="System.CodeDom" Version="$(SystemCodeDomMinimumVersion)" />
- <PackageReference Include="System.Reflection" Version="$(SystemReflectionMinimumVersion)" />
- <PackageReference Include="System.Reflection.Emit.ILGeneration" Version="$(SystemReflectionEmitILGenerationMinimumVersion)" />
- <PackageReference Include="System.Reflection.Emit.Lightweight" Version="$(SystemReflectionEmitLightweightMinimumVersion)" />
+ <PackageReference Include="System.CodeDom" Version="$(SystemCodeDomVersion)" />
</ItemGroup>
<ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.0'">
diff --git a/lang/csharp/src/apache/test/Avro.test.csproj b/lang/csharp/src/apache/test/Avro.test.csproj
index 483945d..a1864d8 100644
--- a/lang/csharp/src/apache/test/Avro.test.csproj
+++ b/lang/csharp/src/apache/test/Avro.test.csproj
@@ -39,7 +39,6 @@
<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="$(MicrosoftNETTestSdkVersion)" />
- <PackageReference Include="System.Buffers" Version="$(SystemBuffersVersion)" />
</ItemGroup>
<ItemGroup>
diff --git a/lang/csharp/src/apache/test/Schema/AliasTest.cs b/lang/csharp/src/apache/test/Schema/AliasTest.cs
index 422e07f..b9a31bb 100644
--- a/lang/csharp/src/apache/test/Schema/AliasTest.cs
+++ b/lang/csharp/src/apache/test/Schema/AliasTest.cs
@@ -73,9 +73,8 @@ namespace Avro.Test
Assert.IsTrue(json == json2);
}
- catch (Exception ex)
+ catch (Exception)
{
- Console.WriteLine(ex.Message);
Assert.IsFalse(valid);
}
}
diff --git a/lang/csharp/versions.props b/lang/csharp/versions.props
index 6ae87d9..2ec4d2e 100644
--- a/lang/csharp/versions.props
+++ b/lang/csharp/versions.props
@@ -23,7 +23,7 @@
<!--
These package versions are the latest, which our tools are packaged with.
These might override the bare minimum requirement of a class library.
- !!! SHIPPED CLASS LIBRARIES SHOULD USE MINIMUMVERSIONs. SEE BELOW !!!
+ !!! SHIPPED CLASS LIBRARIES SHOULD USE MINIMUMVERSIONs FOR SOME LIBRARIES. SEE BELOW !!!
-->
<PropertyGroup Label="Latest Package Versions">
<NewtonsoftJsonVersion>12.0.3</NewtonsoftJsonVersion>
@@ -31,20 +31,17 @@
<SystemReflectionVersion>4.3.0</SystemReflectionVersion>
<SystemReflectionEmitILGenerationVersion>4.7.0</SystemReflectionEmitILGenerationVersion>
<SystemReflectionEmitLightweightVersion>4.7.0</SystemReflectionEmitLightweightVersion>
- <SystemBuffersVersion>4.5.1</SystemBuffersVersion>
</PropertyGroup>
- <PropertyGroup Label="Minimum Package Versions">
- <!--
- !!! ONLY UPDATE Newtonsoft JSON IF FUNCTIONALITY REQUIRES IT !!!
+ <!--
+ These package versions are the bare minimum requriement. Only update the version of these dependencies,
+ if functionality requires it. Leave it up to the users of the library as to whether or not they want the
+ latest and greatest of a particularly dependency.
+ !!! ONLY UPDATE IF FUNCTIONALITY REQUIRES IT !!!
See https://github.com/apache/avro/pull/1126 & https://github.com/apache/avro/pull/981 for more details
- -->
+ -->
+ <PropertyGroup Label="Minimum Package Versions">
<NewtonsoftJsonMinimumVersion>10.0.3</NewtonsoftJsonMinimumVersion>
-
- <SystemCodeDomMinimumVersion>6.0.0</SystemCodeDomMinimumVersion>
- <SystemReflectionMinimumVersion>4.3.0</SystemReflectionMinimumVersion>
- <SystemReflectionEmitILGenerationMinimumVersion>4.7.0</SystemReflectionEmitILGenerationMinimumVersion>
- <SystemReflectionEmitLightweightMinimumVersion>4.7.0</SystemReflectionEmitLightweightMinimumVersion>
</PropertyGroup>
<!--