[GitHub] [ambari-metrics] lucasbak commented on a diff in pull request #52: AMBARI-25402 Please provide jvm metrics for kafka components in Ambari

[GitBox <gi...@apache.org>]

lucasbak commented on code in PR #52:
URL: https://github.com/apache/ambari-metrics/pull/52#discussion_r1015905512


##########
ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.java:
##########
@@ -81,7 +80,6 @@ public class KafkaTimelineMetricsReporter extends AbstractTimelineMetricsSink
   private static final String TIMELINE_DEFAULT_PROTOCOL = "http";
   private static final String EXCLUDED_METRICS_PROPERTY = "external.kafka.metrics.exclude.prefix";
   private static final String INCLUDED_METRICS_PROPERTY = "external.kafka.metrics.include.prefix";
-  private static final String INCLUDED_METRICS_REGEX_PROPERTY = "external.kafka.metrics.include.regex";

Review Comment:
   It was not part for branch-2.7 but as AMBARI-24797 target fix version is 2.8, we should keep it.
   Let's remove this deletion !



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For additional commands, e-mail: commits-help@ambari.apache.org