You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "pitrou (via GitHub)" <gi...@apache.org> on 2024/12/05 14:15:39 UTC
[PR] MINOR: [C++] Assorted CMake improvements [arrow]
pitrou opened a new pull request, #44951:
URL: https://github.com/apache/arrow/pull/44951
### What changes are included in this PR?
1) Disable jemalloc by default
2) Enable mimalloc by default
3) Disable more compute modules by default
### Are these changes tested?
Yes, by existing CI tests.
### Are there any user-facing changes?
Yes, but nothing compatibility-breaking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [C++] Assorted CMake improvements [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on code in PR #44951:
URL: https://github.com/apache/arrow/pull/44951#discussion_r1871473510
##########
cpp/src/arrow/CMakeLists.txt:
##########
@@ -793,10 +777,25 @@ if(ARROW_COMPUTE)
compute/kernels/vector_replace.cc
compute/kernels/vector_run_end_encode.cc
compute/kernels/vector_select_k.cc
- compute/kernels/vector_sort.cc)
+ compute/kernels/vector_sort.cc
+ compute/key_hash_internal.cc
+ compute/key_map_internal.cc
+ compute/light_array_internal.cc
+ compute/row/encode_internal.cc
+ compute/row/compare_internal.cc
+ compute/row/grouper.cc
+ compute/row/row_encoder_internal.cc
+ compute/row/row_internal.cc
+ compute/util.cc
+ compute/util_internal.cc)
Review Comment:
Those two files may be moved into the `row` subdir perhaps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44976: [C++] Enable mimalloc by default, disable jemalloc by default and more [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #44951:
URL: https://github.com/apache/arrow/pull/44951#issuecomment-2536699124
> The minimal build nightly tests seem to be failing because of this, see eg https://github.com/ursacomputing/crossbow/actions/runs/12279407480/job/34263376592
Ah, yes, indeed. It should be a quick fix if anyone is available before I am :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44976: [C++] Assorted CMake improvements [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44951:
URL: https://github.com/apache/arrow/pull/44951#issuecomment-2528141411
Revision: 709e86bdde85048e8badcd48a44d381726192b20
Submitted crossbow builds: [ursacomputing/crossbow @ actions-ffd8ebc12b](https://github.com/ursacomputing/crossbow/branches/all?query=actions-ffd8ebc12b)
|Task|Status|
|----|------|
|example-cpp-minimal-build-static|[](https://github.com/ursacomputing/crossbow/actions/runs/12237887991/job/34134664282)|
|example-cpp-minimal-build-static-system-dependency|[](https://github.com/ursacomputing/crossbow/actions/runs/12237887586/job/34134662169)|
|example-cpp-tutorial|[](https://github.com/ursacomputing/crossbow/actions/runs/12237887990/job/34134664622)|
|test-alpine-linux-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/12237887917/job/34134664245)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/12237888236/job/34134665809)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/12237888502/job/34134667422)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/actions/runs/12237888872/job/34134668512)|
|test-cuda-cpp-ubuntu-20.04-cuda-11.2.2|[](https://github.com/ursacomputing/crossbow/actions/runs/12237888591/job/34134667505)|
|test-cuda-cpp-ubuntu-22.04-cuda-11.7.1|[](https://github.com/ursacomputing/crossbow/actions/runs/12237887616/job/34134662583)|
|test-debian-12-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/12237887778/job/34134663549)|
|test-debian-12-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/12237888157/job/34134664675)|
|test-fedora-39-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/12237888319/job/34134666732)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/12237888300/job/34134665818)|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/12237888329/job/34134666693)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/12237887581/job/34134662227)|
|test-ubuntu-22.04-cpp-20|[](https://github.com/ursacomputing/crossbow/actions/runs/12237887588/job/34134662211)|
|test-ubuntu-22.04-cpp-emscripten|[](https://github.com/ursacomputing/crossbow/actions/runs/12237887952/job/34134664234)|
|test-ubuntu-22.04-cpp-no-threading|[](https://github.com/ursacomputing/crossbow/actions/runs/12237887758/job/34134663534)|
|test-ubuntu-24.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/12237888247/job/34134665877)|
|test-ubuntu-24.04-cpp-bundled-offline|[](https://github.com/ursacomputing/crossbow/actions/runs/12237888365/job/34134666677)|
|test-ubuntu-24.04-cpp-gcc-13-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/12237888061/job/34134664694)|
|test-ubuntu-24.04-cpp-gcc-14|[](https://github.com/ursacomputing/crossbow/actions/runs/12237887960/job/34134664292)|
|test-ubuntu-24.04-cpp-minimal-with-formats|[](https://github.com/ursacomputing/crossbow/actions/runs/12237887567/job/34134662561)|
|test-ubuntu-24.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/12237887643/job/34134662202)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44976: [C++] Assorted CMake improvements [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44951:
URL: https://github.com/apache/arrow/pull/44951#issuecomment-2528077032
Revision: 560bcda290553d5d9da8e59c95c13d0f3067d962
Submitted crossbow builds: [ursacomputing/crossbow @ actions-81ada84eaa](https://github.com/ursacomputing/crossbow/branches/all?query=actions-81ada84eaa)
|Task|Status|
|----|------|
|example-cpp-minimal-build-static|[](https://github.com/ursacomputing/crossbow/actions/runs/12237415510/job/34133109531)|
|example-cpp-minimal-build-static-system-dependency|[](https://github.com/ursacomputing/crossbow/actions/runs/12237415482/job/34133109360)|
|example-cpp-tutorial|[](https://github.com/ursacomputing/crossbow/actions/runs/12237416245/job/34133113390)|
|test-alpine-linux-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/12237415671/job/34133110156)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/12237415255/job/34133107342)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/12237415283/job/34133108258)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/actions/runs/12237416236/job/34133113402)|
|test-cuda-cpp-ubuntu-20.04-cuda-11.2.2|[](https://github.com/ursacomputing/crossbow/actions/runs/12237415246/job/34133106912)|
|test-cuda-cpp-ubuntu-22.04-cuda-11.7.1|[](https://github.com/ursacomputing/crossbow/actions/runs/12237415493/job/34133109755)|
|test-debian-12-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/12237415622/job/34133110193)|
|test-debian-12-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/12237415551/job/34133110149)|
|test-fedora-39-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/12237416086/job/34133113381)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/12237415914/job/34133112122)|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/12237415125/job/34133107020)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/12237415268/job/34133107465)|
|test-ubuntu-22.04-cpp-20|[](https://github.com/ursacomputing/crossbow/actions/runs/12237415366/job/34133108691)|
|test-ubuntu-22.04-cpp-emscripten|[](https://github.com/ursacomputing/crossbow/actions/runs/12237415409/job/34133108787)|
|test-ubuntu-22.04-cpp-no-threading|[](https://github.com/ursacomputing/crossbow/actions/runs/12237415141/job/34133106935)|
|test-ubuntu-24.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/12237415479/job/34133109364)|
|test-ubuntu-24.04-cpp-bundled-offline|[](https://github.com/ursacomputing/crossbow/actions/runs/12237415808/job/34133112031)|
|test-ubuntu-24.04-cpp-gcc-13-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/12237415502/job/34133109741)|
|test-ubuntu-24.04-cpp-gcc-14|[](https://github.com/ursacomputing/crossbow/actions/runs/12237415809/job/34133112133)|
|test-ubuntu-24.04-cpp-minimal-with-formats|[](https://github.com/ursacomputing/crossbow/actions/runs/12237415279/job/34133108247)|
|test-ubuntu-24.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/12237415475/job/34133109777)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44976: [C++] Enable mimalloc by default, disable jemalloc by default and more [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #44951:
URL: https://github.com/apache/arrow/pull/44951#issuecomment-2538425562
I submitted https://github.com/apache/arrow/pull/45007 to fix the Python CI failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [C++] Assorted CMake improvements [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44951:
URL: https://github.com/apache/arrow/pull/44951#issuecomment-2520468511
Revision: 560bcda290553d5d9da8e59c95c13d0f3067d962
Submitted crossbow builds: [ursacomputing/crossbow @ actions-a13a6c4f15](https://github.com/ursacomputing/crossbow/branches/all?query=actions-a13a6c4f15)
|Task|Status|
|----|------|
|example-cpp-minimal-build-static|[](https://github.com/ursacomputing/crossbow/actions/runs/12181688285/job/33978914093)|
|example-cpp-minimal-build-static-system-dependency|[](https://github.com/ursacomputing/crossbow/actions/runs/12181687813/job/33978911322)|
|example-cpp-tutorial|[](https://github.com/ursacomputing/crossbow/actions/runs/12181687781/job/33978911012)|
|test-alpine-linux-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/12181687495/job/33978908546)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/12181688052/job/33978912051)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/12181687978/job/33978911600)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/actions/runs/12181687716/job/33978909878)|
|test-cuda-cpp-ubuntu-20.04-cuda-11.2.2|[](https://github.com/ursacomputing/crossbow/actions/runs/12181687931/job/33978911920)|
|test-cuda-cpp-ubuntu-22.04-cuda-11.7.1|[](https://github.com/ursacomputing/crossbow/actions/runs/12181688096/job/33978911533)|
|test-debian-12-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/12181688072/job/33978912152)|
|test-debian-12-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/12181687820/job/33978911422)|
|test-fedora-39-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/12181688107/job/33978912741)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/12181687719/job/33978909819)|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/12181688007/job/33978912707)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/12181687857/job/33978910972)|
|test-ubuntu-22.04-cpp-20|[](https://github.com/ursacomputing/crossbow/actions/runs/12181687938/job/33978912714)|
|test-ubuntu-22.04-cpp-emscripten|[](https://github.com/ursacomputing/crossbow/actions/runs/12181687859/job/33978910990)|
|test-ubuntu-22.04-cpp-no-threading|[](https://github.com/ursacomputing/crossbow/actions/runs/12181687501/job/33978908527)|
|test-ubuntu-24.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/12181687477/job/33978908509)|
|test-ubuntu-24.04-cpp-bundled-offline|[](https://github.com/ursacomputing/crossbow/actions/runs/12181687499/job/33978908568)|
|test-ubuntu-24.04-cpp-gcc-13-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/12181687955/job/33978912052)|
|test-ubuntu-24.04-cpp-gcc-14|[](https://github.com/ursacomputing/crossbow/actions/runs/12181687628/job/33978908908)|
|test-ubuntu-24.04-cpp-minimal-with-formats|[](https://github.com/ursacomputing/crossbow/actions/runs/12181688117/job/33978911813)|
|test-ubuntu-24.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/12181687905/job/33978911027)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [C++] Assorted CMake improvements [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #44951:
URL: https://github.com/apache/arrow/pull/44951#issuecomment-2520461747
@github-actions crossbow submit -g cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [C++] Assorted CMake improvements [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #44951:
URL: https://github.com/apache/arrow/pull/44951#issuecomment-2521974195
Could you open at least one issue for this?
This is not MINOR in our definition: https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [C++] Assorted CMake improvements [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #44951:
URL: https://github.com/apache/arrow/pull/44951#discussion_r1872498838
##########
cpp/src/arrow/CMakeLists.txt:
##########
@@ -793,10 +777,25 @@ if(ARROW_COMPUTE)
compute/kernels/vector_replace.cc
compute/kernels/vector_run_end_encode.cc
compute/kernels/vector_select_k.cc
- compute/kernels/vector_sort.cc)
+ compute/kernels/vector_sort.cc
+ compute/key_hash_internal.cc
+ compute/key_map_internal.cc
+ compute/light_array_internal.cc
+ compute/row/encode_internal.cc
+ compute/row/compare_internal.cc
+ compute/row/grouper.cc
+ compute/row/row_encoder_internal.cc
+ compute/row/row_internal.cc
+ compute/util.cc
+ compute/util_internal.cc)
Review Comment:
Could you add a description why we should move them to the `ARROW_COMPUTE` block to the PR description?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [C++] Assorted CMake improvements [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #44951:
URL: https://github.com/apache/arrow/pull/44951#issuecomment-2520456619
Not sure this is really minor, or if we want to create separate issues per individual change (though that may be overkill). Thoughts @kou ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44976: [C++] Enable mimalloc by default, disable jemalloc by default and more [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #44951:
URL: https://github.com/apache/arrow/pull/44951
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44976: [C++] Assorted CMake improvements [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #44951:
URL: https://github.com/apache/arrow/pull/44951#issuecomment-2528134728
@github-actions crossbow submit -g cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44976: [C++] Enable mimalloc by default, disable jemalloc by default and more [arrow]
Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche commented on PR #44951:
URL: https://github.com/apache/arrow/pull/44951#issuecomment-2536678305
The minimal build nightly tests seem to be failing because of this, see eg https://github.com/ursacomputing/crossbow/actions/runs/12279407480/job/34263376592
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44976: [C++] Assorted CMake improvements [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44951:
URL: https://github.com/apache/arrow/pull/44951#issuecomment-2528061532
:warning: GitHub issue #44976 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44976: [C++] Assorted CMake improvements [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #44951:
URL: https://github.com/apache/arrow/pull/44951#issuecomment-2528070534
@github-actions crossbow submit -g cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44976: [C++] Enable mimalloc by default, disable jemalloc by default and more [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #44951:
URL: https://github.com/apache/arrow/pull/44951#issuecomment-2579373020
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit b907c5dadb516b525c8fafbf34b0116d44044733.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/35356607979) has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org