You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by gu...@apache.org on 2015/11/12 21:22:02 UTC
kafka git commit: KAFKA-2822: DescribeConsumerGroup now returns empty
list for non-existent group.
Repository: kafka
Updated Branches:
refs/heads/trunk 1408c670e -> 28d71ce5e
KAFKA-2822: DescribeConsumerGroup now returns empty list for non-existent group.
…tent group, it used to throw IllegalArgumentException
Author: Ashish Singh <as...@cloudera.com>
Reviewers: Jason Gustafson, Guozhang Wang
Closes #515 from SinghAsDev/KAFKA-2822
Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/28d71ce5
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/28d71ce5
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/28d71ce5
Branch: refs/heads/trunk
Commit: 28d71ce5e06a17248f944147e850f3e5e029bdee
Parents: 1408c67
Author: Ashish Singh <as...@cloudera.com>
Authored: Thu Nov 12 12:28:08 2015 -0800
Committer: Guozhang Wang <wa...@gmail.com>
Committed: Thu Nov 12 12:28:08 2015 -0800
----------------------------------------------------------------------
.../test/scala/integration/kafka/api/AdminClientTest.scala | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kafka/blob/28d71ce5/core/src/test/scala/integration/kafka/api/AdminClientTest.scala
----------------------------------------------------------------------
diff --git a/core/src/test/scala/integration/kafka/api/AdminClientTest.scala b/core/src/test/scala/integration/kafka/api/AdminClientTest.scala
index 072f8eb..5930d13 100644
--- a/core/src/test/scala/integration/kafka/api/AdminClientTest.scala
+++ b/core/src/test/scala/integration/kafka/api/AdminClientTest.scala
@@ -113,12 +113,6 @@ class AdminClientTest extends IntegrationTestHarness with Logging {
@Test
def testDescribeConsumerGroupForNonExistentGroup() {
val nonExistentGroup = "non" + groupId
- try {
- client.describeConsumerGroup(nonExistentGroup)
- fail("Should have failed for non existent group.")
- } catch {
- case ex: IllegalArgumentException => // Pass
- case _: Throwable => fail("Should have failed for non existent group with IllegalArgumentException.")
- }
+ assertTrue("Expected empty ConsumerSummary list", client.describeConsumerGroup(nonExistentGroup).isEmpty)
}
}