You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/09/21 07:43:27 UTC

[GitHub] [camel] orpiske opened a new pull request #6129: CAMEL-13215 and CAMEL-16981: consolidate consumerStreams and consumersCount

orpiske opened a new pull request #6129:
URL: https://github.com/apache/camel/pull/6129


   This path consolidates consumerStreams into consumersCount. Previously
   consumerStreams was used to adjust the size of the thread pool used for
   the consumer threads.
   With this change the size of the thread pool is always the same size of
   the number of consumers, preventing situations where consumers were
   created unnecessarily and unused due to improperly sized thread pool.
   
   It also clarifies the documentation (CAMEL-16981) and consumer behavior.
   
   
   <!-- Uncomment and fill this section if your PR is not trivial
   - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
   - [ ] Each commit in the pull request should have a meaningful subject line and body.
   - [ ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
   - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
   Below are the contribution guidelines:
   https://github.com/apache/camel/blob/main/CONTRIBUTING.md
   -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] orpiske merged pull request #6129: CAMEL-13215 and CAMEL-16981: consolidate consumerStreams and consumersCount

Posted by GitBox <gi...@apache.org>.
orpiske merged pull request #6129:
URL: https://github.com/apache/camel/pull/6129


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] orpiske commented on pull request #6129: CAMEL-13215 and CAMEL-16981: consolidate consumerStreams and consumersCount

Posted by GitBox <gi...@apache.org>.
orpiske commented on pull request #6129:
URL: https://github.com/apache/camel/pull/6129#issuecomment-923724260


   I believe we could remove the `consumerStreams` parameter in 3.13, but thought it would be better to deprecated for now to give time for users to adjust.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] davsclaus commented on pull request #6129: CAMEL-13215 and CAMEL-16981: consolidate consumerStreams and consumersCount

Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #6129:
URL: https://github.com/apache/camel/pull/6129#issuecomment-923729359


   @orpiske its fine to remove and add a note in the upgrade guide.
   We want these non LTS release to go fast. And its an option that is hardly in use.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] orpiske commented on pull request #6129: CAMEL-13215 and CAMEL-16981: consolidate consumerStreams and consumersCount

Posted by GitBox <gi...@apache.org>.
orpiske commented on pull request #6129:
URL: https://github.com/apache/camel/pull/6129#issuecomment-923730180


   > @orpiske its fine to remove and add a note in the upgrade guide.
   > We want these non LTS release to go fast. And its an option that is hardly in use.
   
   Cool, thanks for the heads up. In this case, I'll go ahead and remove it right away. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org