You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/03/10 07:29:16 UTC

[GitHub] [cloudstack] Pearl1594 opened a new pull request #6086: UI: Fix route to domain details

Pearl1594 opened a new pull request #6086:
URL: https://github.com/apache/cloudstack/pull/6086


   ### Description
   
   This PR fixes router link to domain details
   <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   <!--- ********************************************************************************* -->
   <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- ********************************************************************************* -->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [X] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [X] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6086: UI: Fix route to domain details

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6086:
URL: https://github.com/apache/cloudstack/pull/6086#issuecomment-1063751156


   @Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr commented on pull request #6086: UI: Fix route to domain details

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #6086:
URL: https://github.com/apache/cloudstack/pull/6086#issuecomment-1063767514


   @Pearl1594 don't think it is related but getting error on navigation,
   ![nav-error](https://user-images.githubusercontent.com/153340/157615763-345981c2-05bd-48bf-9d44-bce8bf437211.gif)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] Pearl1594 commented on pull request #6086: UI: Fix route to domain details

Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #6086:
URL: https://github.com/apache/cloudstack/pull/6086#issuecomment-1063750784


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6086: UI: Fix route to domain details

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6086:
URL: https://github.com/apache/cloudstack/pull/6086#issuecomment-1063754912


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6086 (SL-JID-1237)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] nvazquez commented on pull request #6086: UI: Fix route to domain details

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #6086:
URL: https://github.com/apache/cloudstack/pull/6086#issuecomment-1063917800


   Hi @utchoang have any hint on what could be causing the navigation to back issue? It seems like when clicking the back button the wrong UUID is sent. Anyways this would need a separate issue


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] nvazquez merged pull request #6086: UI: Fix route to domain details

Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #6086:
URL: https://github.com/apache/cloudstack/pull/6086


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] Pearl1594 commented on pull request #6086: UI: Fix route to domain details

Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #6086:
URL: https://github.com/apache/cloudstack/pull/6086#issuecomment-1063778374


   Yes @shwstppr  that's something I've been investigating.. It's not related to this PR.. I noticed this on the QA server too..


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org