You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Jordan Birdsell (Code Review)" <ge...@cloudera.org> on 2016/10/01 19:11:46 UTC

[kudu-CR] [docs] Python updates for development page 

Jordan Birdsell has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4586

Change subject: [docs] Python updates for development page
......................................................................

[docs] Python updates for development page

Updates to the Developing Applications with Kudu page for Python.
Additionally, this updates some of the github example references.

Change-Id: I028e86b6bc35f36fd1a4752b52463f5d0fd75f76
---
M docs/developing.adoc
1 file changed, 113 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/4586/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I028e86b6bc35f36fd1a4752b52463f5d0fd75f76
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>

[kudu-CR] [docs] Python updates for development page

Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.

Change subject: [docs] Python updates for development page
......................................................................


Patch Set 7: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/4586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I028e86b6bc35f36fd1a4752b52463f5d0fd75f76
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] [docs] Python updates for development page

Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/4586

to look at the new patch set (#4).

Change subject: [docs] Python updates for development page
......................................................................

[docs] Python updates for development page

Updates to the Developing Applications with Kudu page for Python.
Additionally, this updates some of the github example references.

Change-Id: I028e86b6bc35f36fd1a4752b52463f5d0fd75f76
---
M docs/developing.adoc
1 file changed, 69 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/4586/4
-- 
To view, visit http://gerrit.cloudera.org:8080/4586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I028e86b6bc35f36fd1a4752b52463f5d0fd75f76
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] [docs] Python updates for development page

Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Jordan Birdsell has submitted this change and it was merged.

Change subject: [docs] Python updates for development page
......................................................................


[docs] Python updates for development page

Updates to the Developing Applications with Kudu page for Python.
Additionally, this updates some of the github example references.

Change-Id: I028e86b6bc35f36fd1a4752b52463f5d0fd75f76
Reviewed-on: http://gerrit.cloudera.org:8080/4586
Reviewed-by: David Ribeiro Alves <dr...@apache.org>
Tested-by: Kudu Jenkins
---
M docs/developing.adoc
1 file changed, 72 insertions(+), 7 deletions(-)

Approvals:
  David Ribeiro Alves: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/4586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I028e86b6bc35f36fd1a4752b52463f5d0fd75f76
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] [docs] Python updates for development page

Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Jordan Birdsell has posted comments on this change.

Change subject: [docs] Python updates for development page
......................................................................


Patch Set 3:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/4586/1/docs/developing.adoc
File docs/developing.adoc:

PS1, Line 58: Python API to
> nit: maybe Kudu Python API?
Done


PS1, Line 59: external program
> whats "external program" in this context?
Clarified


PS1, Line 61: An experimental plugin for using graphite-web with Kudu as a backend
> I didn't know this existed, nice.
:)


Line 158: === Kudu Python Client
> I like the example, but maybe we could make it more succinct? This is much 
Shortened it up a bit, let me know what you think


-- 
To view, visit http://gerrit.cloudera.org:8080/4586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I028e86b6bc35f36fd1a4752b52463f5d0fd75f76
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] [docs] Python updates for development page

Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/4586

to look at the new patch set (#3).

Change subject: [docs] Python updates for development page
......................................................................

[docs] Python updates for development page

Updates to the Developing Applications with Kudu page for Python.
Additionally, this updates some of the github example references.

Change-Id: I028e86b6bc35f36fd1a4752b52463f5d0fd75f76
---
M docs/developing.adoc
1 file changed, 73 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/4586/3
-- 
To view, visit http://gerrit.cloudera.org:8080/4586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I028e86b6bc35f36fd1a4752b52463f5d0fd75f76
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [docs] Python updates for development page

Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Jordan Birdsell has posted comments on this change.

Change subject: [docs] Python updates for development page
......................................................................


Patch Set 1:

Going to table this until closer to release time....may be some significant changes by that time.

-- 
To view, visit http://gerrit.cloudera.org:8080/4586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I028e86b6bc35f36fd1a4752b52463f5d0fd75f76
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] [docs] Python updates for development page

Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.

Change subject: [docs] Python updates for development page
......................................................................


Patch Set 6: Code-Review+2

(1 comment)

Feel free to address the nit, +2 yourself and push

http://gerrit.cloudera.org:8080/#/c/4586/6/docs/developing.adoc
File docs/developing.adoc:

Line 213: 
nit: extra line


-- 
To view, visit http://gerrit.cloudera.org:8080/4586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I028e86b6bc35f36fd1a4752b52463f5d0fd75f76
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] [docs] Python updates for development page

Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/4586

to look at the new patch set (#6).

Change subject: [docs] Python updates for development page
......................................................................

[docs] Python updates for development page

Updates to the Developing Applications with Kudu page for Python.
Additionally, this updates some of the github example references.

Change-Id: I028e86b6bc35f36fd1a4752b52463f5d0fd75f76
---
M docs/developing.adoc
1 file changed, 73 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/4586/6
-- 
To view, visit http://gerrit.cloudera.org:8080/4586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I028e86b6bc35f36fd1a4752b52463f5d0fd75f76
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] [docs] Python updates for development page

Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Jordan Birdsell has posted comments on this change.

Change subject: [docs] Python updates for development page
......................................................................


Patch Set 6:

(7 comments)

http://gerrit.cloudera.org:8080/#/c/4586/3/docs/developing.adoc
File docs/developing.adoc:

PS3, Line 56: generates 
> typo
Done


PS3, Line 61: backend
> missing period at the end of sentence
Done


PS3, Line 160: part
> s/much/part
Done


PS3, Line 170: for a new table
> s/all of this/for a new
Done


PS3, Line 205: 
> q can we do more than one of these within a session.apply()? If so can you 
Changed, however, you bring up a good point, enabling a list of writeops might be nice to have in the future


PS3, Line 209: 
> I forget do all of these raise exceptions or do they return a status. If it
it does, gives you the "some errors occured" error. Added a try except block to demonstrate that.


PS3, Line 216: # Note: This doesn't scale for lar
> Add a note that this doesn't scale for huge scans
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I028e86b6bc35f36fd1a4752b52463f5d0fd75f76
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] [docs] Python updates for development page

Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.

Change subject: [docs] Python updates for development page
......................................................................


Patch Set 1:

sgtm

-- 
To view, visit http://gerrit.cloudera.org:8080/4586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I028e86b6bc35f36fd1a4752b52463f5d0fd75f76
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] [docs] Python updates for development page

Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.

Change subject: [docs] Python updates for development page
......................................................................


Patch Set 3:

(7 comments)

http://gerrit.cloudera.org:8080/#/c/4586/3/docs/developing.adoc
File docs/developing.adoc:

PS3, Line 56: generatess
typo


PS3, Line 61: backend
missing period at the end of sentence


PS3, Line 160: much
s/much/part


PS3, Line 170: to be used to create a new
s/all of this/for a new


PS3, Line 205: table.new_delete({'key': 2})
q can we do more than one of these within a session.apply()? If so can you use an example? If not do we really need the weird wrapping or is this idiomatic python that I'm missing.


PS3, Line 209: session.flush()
I forget do all of these raise exceptions or do they return a status. If its the latter can you assign it/use it?


PS3, Line 216: # Open Scanner and read all tuples
Add a note that this doesn't scale for huge scans


-- 
To view, visit http://gerrit.cloudera.org:8080/4586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I028e86b6bc35f36fd1a4752b52463f5d0fd75f76
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] [WIP][docs] Python updates for development page

Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/4586

to look at the new patch set (#2).

Change subject: [WIP][docs] Python updates for development page
......................................................................

[WIP][docs] Python updates for development page

Updates to the Developing Applications with Kudu page for Python.
Additionally, this updates some of the github example references.

Change-Id: I028e86b6bc35f36fd1a4752b52463f5d0fd75f76
---
M docs/developing.adoc
1 file changed, 113 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/4586/2
-- 
To view, visit http://gerrit.cloudera.org:8080/4586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I028e86b6bc35f36fd1a4752b52463f5d0fd75f76
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [docs] Python updates for development page

Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Hello David Ribeiro Alves, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/4586

to look at the new patch set (#7).

Change subject: [docs] Python updates for development page
......................................................................

[docs] Python updates for development page

Updates to the Developing Applications with Kudu page for Python.
Additionally, this updates some of the github example references.

Change-Id: I028e86b6bc35f36fd1a4752b52463f5d0fd75f76
---
M docs/developing.adoc
1 file changed, 72 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/4586/7
-- 
To view, visit http://gerrit.cloudera.org:8080/4586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I028e86b6bc35f36fd1a4752b52463f5d0fd75f76
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] [docs] Python updates for development page

Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/4586

to look at the new patch set (#5).

Change subject: [docs] Python updates for development page
......................................................................

[docs] Python updates for development page

Updates to the Developing Applications with Kudu page for Python.
Additionally, this updates some of the github example references.

Change-Id: I028e86b6bc35f36fd1a4752b52463f5d0fd75f76
---
M docs/developing.adoc
1 file changed, 70 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/4586/5
-- 
To view, visit http://gerrit.cloudera.org:8080/4586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I028e86b6bc35f36fd1a4752b52463f5d0fd75f76
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] [docs] Python updates for development page

Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.

Change subject: [docs] Python updates for development page
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/4586/1/docs/developing.adoc
File docs/developing.adoc:

PS1, Line 58: API in Python
nit: maybe Kudu Python API?


PS1, Line 59: external program
whats "external program" in this context?


PS1, Line 61: An experimental plugin for using graphite-web with Kudu as a backend
I didn't know this existed, nice.


Line 158: === Kudu Python Client
I like the example, but maybe we could make it more succinct? This is much more detailed than the spark client above.


-- 
To view, visit http://gerrit.cloudera.org:8080/4586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I028e86b6bc35f36fd1a4752b52463f5d0fd75f76
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes