[GitHub] [arrow] jorisvandenbossche commented on a diff in pull request #14660: ARROW-18341: [Doc][Python] Update note about bundling Arrow C++ on Windows

[GitBox <gi...@apache.org>]

jorisvandenbossche commented on code in PR #14660:
URL: https://github.com/apache/arrow/pull/14660#discussion_r1024199341


##########
docs/source/developers/python.rst:
##########
@@ -563,19 +563,25 @@ Then run the unit tests with:
    the Python extension. This is recommended for development as it allows the
    C++ libraries to be re-built separately.
 
-   If you want to bundle the Arrow C++ libraries with ``pyarrow``, add
-   the ``--bundle-arrow-cpp`` option when building:
+   If you are using conda package manager then conda will ensure Arrow C++
+   libraries are found. In case you are *not* using conda then you have to
+
+   * add the path of installed DLL libraries to ``PATH`` every time before
+     importing ``pyarrow``, or
+   * bundle the Arrow C++ libraries with ``pyarrow``.
+
+   If you want to bundle the Arrow C++ libraries with ``pyarrow``, use
+   ``PYARROW_BUNDLE_ARROW_CPP`` environment variable before building pyarrow:
 
    .. code-block::
 
-      $ python setup.py build_ext --bundle-arrow-cpp
+      $ pushd arrow\python
+      $ export PYARROW_BUNDLE_ARROW_CPP=1
+      $ python -m pytest pyarrow

Review Comment:
   This should be building pyarrow? (not testing) So `python setup.py build_ext --inplace`? (that is what is being used above) or a pip install



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org