You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/05/18 19:12:22 UTC

[GitHub] [incubator-nuttx] jlaitine commented on a diff in pull request #6287: stm32h7: allow definition of HSI divider in board config

jlaitine commented on code in PR #6287:
URL: https://github.com/apache/incubator-nuttx/pull/6287#discussion_r876253507


##########
arch/arm/src/stm32h7/stm32h7x3xx_rcc.c:
##########
@@ -144,10 +148,6 @@ static inline void rcc_reset(void)
               RCC_CR_PLL2ON | RCC_CR_PLL3ON |
               RCC_CR_HSIDIV_MASK);
 
-  /* Set HSI predivider to default (4, 16MHz) */

Review Comment:
   No problem. I don't have access to that (proprietary) HW any longer, and I don't remember any more why it was done like that. Anyhow, now the original code looks wrong and the patch looks correct to me.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org