You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jmeter.apache.org by ra0077 <gi...@git.apache.org> on 2016/04/19 09:16:56 UTC

[GitHub] jmeter pull request: Bug59353_NewPartInChanges.html

GitHub user ra0077 opened a pull request:

    https://github.com/apache/jmeter/pull/203

    Bug59353_NewPartInChanges.html

    Hi,
    
    I propose to have a dedicated part called "Deprecated and removed
    elements" in "Incompatible changes" part in changes.xml
    
    Like that it will be more visible for user
    
    I have add Spline Visualizer listener and Distribution Graph listener
    which are not mentioned in changes.xml
    
    Antonio

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ra0077/jmeter Bug59353_NewPartInChanges.html

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/jmeter/pull/203.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #203
    
----
commit c212b3eb1d507374de24a2715315c8cf381a8fca
Author: ra0077 <ra...@gmail.com>
Date:   2016-04-19T07:16:09Z

    Bug59353_NewPartInChanges.html
    
    Hi,
    
    I propose to have a dedicated part called "Deprecated and removed
    elements" in "Incompatible changes" part in changes.xml
    
    Like that it will be more visible for user
    
    I have add Spline Visualizer listener and Distribution Graph listener
    which are not mentioned in changes.xml
    
    Antonio

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter pull request: Bug59353_NewPartInChanges.html

Posted by ra0077 <gi...@git.apache.org>.

Github user ra0077 closed the pull request at:

    https://github.com/apache/jmeter/pull/203


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter pull request: Bug59353_NewPartInChanges.html

Posted by pmouawad <gi...@git.apache.org>.

Github user pmouawad commented on the pull request:

    https://github.com/apache/jmeter/pull/203#issuecomment-212119330
  
    Hi Antonio,
    I think it's a good idea.
    
    But if you want to create a PR for docs, you must update changes.xml .
    All html files are generated from xml.
    
    Regards
    Philippe


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter pull request: Bug59353_NewPartInChanges.html

Posted by ra0077 <gi...@git.apache.org>.

Github user ra0077 commented on the pull request:

    https://github.com/apache/jmeter/pull/203#issuecomment-212153353
  
    Hi Philippe,
    
    My title of PR is not good
    
    I have modified xdocs/changes.xml file and not the html file
    
    Antonio



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter pull request: Bug59353_NewPartInChanges.html

Posted by ra0077 <gi...@git.apache.org>.

Github user ra0077 commented on the pull request:

    https://github.com/apache/jmeter/pull/203#issuecomment-213097486
  
    Merge by Milamber
    
    This closes #203
    
    Antonio



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---