You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Andrew Jorgensen <an...@andrewjorgensen.com> on 2015/07/15 18:58:09 UTC
Review Request 36511: Removes version on virtual pacakge in debian
control
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36511/
-----------------------------------------------------------
Review request for Aurora.
Repository: aurora
Description
-------
java-runtime-headless is a virtual package and cannot have a version
specified. The consequence of this is that the built packages require openjdk-8
be installed which prevented the packages from working with oracle-java8.
java8-runtime-headless is a virtual package provided by both openjdk-8
and oracle-java8 so the resulting debian packages can be installed on a
machine with either versions of java8 installed.
Diffs
-----
build-support/packaging/debian/control ff62ea19f27e1937549aca1c1effd108626453bc
Diff: https://reviews.apache.org/r/36511/diff/
Testing
-------
Thanks,
Andrew Jorgensen
Re: Review Request 36511: Removes version on virtual pacakge in debian
control
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36511/#review91755
-----------------------------------------------------------
Ship it!
Master (d9dac92) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On July 15, 2015, 4:58 p.m., Andrew Jorgensen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36511/
> -----------------------------------------------------------
>
> (Updated July 15, 2015, 4:58 p.m.)
>
>
> Review request for Aurora.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> java-runtime-headless is a virtual package and cannot have a version
> specified. The consequence of this is that the built packages require openjdk-8
> be installed which prevented the packages from working with oracle-java8.
> java8-runtime-headless is a virtual package provided by both openjdk-8
> and oracle-java8 so the resulting debian packages can be installed on a
> machine with either versions of java8 installed.
>
>
> Diffs
> -----
>
> build-support/packaging/debian/control ff62ea19f27e1937549aca1c1effd108626453bc
>
> Diff: https://reviews.apache.org/r/36511/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Jorgensen
>
>
Re: Review Request 36511: Removes version on virtual pacakge in debian
control
Posted by Andrew Jorgensen <an...@andrewjorgensen.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36511/
-----------------------------------------------------------
(Updated July 15, 2015, 5:48 p.m.)
Review request for Aurora.
Bugs: AURORA-1400
https://issues.apache.org/jira/browse/AURORA-1400
Repository: aurora
Description
-------
java-runtime-headless is a virtual package and cannot have a version
specified. The consequence of this is that the built packages require openjdk-8
be installed which prevented the packages from working with oracle-java8.
java8-runtime-headless is a virtual package provided by both openjdk-8
and oracle-java8 so the resulting debian packages can be installed on a
machine with either versions of java8 installed.
Diffs
-----
build-support/packaging/debian/control ff62ea19f27e1937549aca1c1effd108626453bc
Diff: https://reviews.apache.org/r/36511/diff/
Testing (updated)
-------
Started two docker containers, one with oracle-java8 and the other with openjdk-8. I was able to install the aurora-scheduler package in both containers with this change.
Thanks,
Andrew Jorgensen
Re: Review Request 36511: Removes version on virtual pacakge in debian
control
Posted by Andrew Jorgensen <an...@andrewjorgensen.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36511/
-----------------------------------------------------------
(Updated July 15, 2015, 5:46 p.m.)
Review request for Aurora.
Bugs: AURORA-1400
https://issues.apache.org/jira/browse/AURORA-1400
Repository: aurora
Description
-------
java-runtime-headless is a virtual package and cannot have a version
specified. The consequence of this is that the built packages require openjdk-8
be installed which prevented the packages from working with oracle-java8.
java8-runtime-headless is a virtual package provided by both openjdk-8
and oracle-java8 so the resulting debian packages can be installed on a
machine with either versions of java8 installed.
Diffs
-----
build-support/packaging/debian/control ff62ea19f27e1937549aca1c1effd108626453bc
Diff: https://reviews.apache.org/r/36511/diff/
Testing
-------
Thanks,
Andrew Jorgensen