You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2018/09/23 16:52:15 UTC

[GitHub] brodybits commented on issue #176: Migrate tests to Jasmine 3 driven by Karma

brodybits commented on issue #176: Migrate tests to Jasmine 3 driven by Karma
URL: https://github.com/apache/cordova-js/pull/176#issuecomment-423830401
 
 
   On Fri, Sep 21, 2018 at 6:15 AM Raphael von der Grün <
   notifications@github.com> wrote:
   
   > This PR does the following:
   >
   >    - Migrate test sources from Jasmine 1 to Jasmine 3 (Closes #140
   >    <https://github.com/apache/cordova-js/pull/140>)
   >    - Setup tests so they are run by Karma in Headless Chrome against the
   >    build produced by our Grunt task compile
   >    - Remove obsolete Grunt tasks test, cover and all of their
   >    dependencies, thus resolving npm audit warnings (Resolves #171
   >    <https://github.com/apache/cordova-js/issues/171>)
   >
   >
   <3
   
   I will probably need 1-2 days to review formally.
   
   >
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org