You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2022/08/30 22:28:39 UTC
[Impala-ASF-CR] IMPALA-9448: Use Ozone TDE in minicluster
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18931
Change subject: IMPALA-9448: Use Ozone TDE in minicluster
......................................................................
IMPALA-9448: Use Ozone TDE in minicluster
Enables Ozone's Transparent Data Encryption when creating a bucket in
the minicluster. Requires `-format` to turn on encryption in an existing
minicluster.
Tested by running e2e and custom cluster tests with Ozone.
Change-Id: Icd82967cdab7b222e5876936f39e5198ba9773ea
---
M testdata/bin/run-all.sh
A testdata/bin/setup-dfs-keys.sh
M testdata/bin/setup-hdfs-env.sh
M testdata/cluster/admin
4 files changed, 38 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/18931/1
--
To view, visit http://gerrit.cloudera.org:8080/18931
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icd82967cdab7b222e5876936f39e5198ba9773ea
Gerrit-Change-Number: 18931
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-9448: Use Ozone TDE in minicluster
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18931 )
Change subject: IMPALA-9448: Use Ozone TDE in minicluster
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11265/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18931
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd82967cdab7b222e5876936f39e5198ba9773ea
Gerrit-Change-Number: 18931
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 30 Aug 2022 22:49:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9448: Use Ozone TDE in minicluster
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18931 )
Change subject: IMPALA-9448: Use Ozone TDE in minicluster
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8549/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/18931
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd82967cdab7b222e5876936f39e5198ba9773ea
Gerrit-Change-Number: 18931
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Sep 2022 20:43:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9448: Use Ozone TDE in minicluster
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18931 )
Change subject: IMPALA-9448: Use Ozone TDE in minicluster
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18931
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd82967cdab7b222e5876936f39e5198ba9773ea
Gerrit-Change-Number: 18931
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Sep 2022 21:51:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9448: Use Ozone TDE in minicluster
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18931 )
Change subject: IMPALA-9448: Use Ozone TDE in minicluster
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11318/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18931
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd82967cdab7b222e5876936f39e5198ba9773ea
Gerrit-Change-Number: 18931
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Sep 2022 17:52:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9448: Use Ozone TDE in minicluster
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18931 )
Change subject: IMPALA-9448: Use Ozone TDE in minicluster
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18931
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd82967cdab7b222e5876936f39e5198ba9773ea
Gerrit-Change-Number: 18931
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 Sep 2022 01:38:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9448: Use Ozone TDE in minicluster
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18931 )
Change subject: IMPALA-9448: Use Ozone TDE in minicluster
......................................................................
Patch Set 2:
(1 comment)
> Patch Set 2:
>
> So, is the plan for the Ozone tests to always run on an encrypted bucket?
I haven't seen a reason to avoid it. Although it could make sense to have a flag to turn it off.
http://gerrit.cloudera.org:8080/#/c/18931/2/testdata/bin/run-all.sh
File testdata/bin/run-all.sh:
http://gerrit.cloudera.org:8080/#/c/18931/2/testdata/bin/run-all.sh@a84
PS2, Line 84:
Removed this line because this section doesn't have anything to do with KMS.
--
To view, visit http://gerrit.cloudera.org:8080/18931
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd82967cdab7b222e5876936f39e5198ba9773ea
Gerrit-Change-Number: 18931
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Sep 2022 21:12:02 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9448: Use Ozone TDE in minicluster
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18931 )
Change subject: IMPALA-9448: Use Ozone TDE in minicluster
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18931/3/bin/impala-config.sh
File bin/impala-config.sh:
http://gerrit.cloudera.org:8080/#/c/18931/3/bin/impala-config.sh@660
PS3, Line 660: export OZONE_VOLUME="impala"
: export OZONE_BUCKET="base"
: export DEFAULT_FS="o3fs://${OZONE_BUCKET}.${OZONE_VOLUME}.${INTERNAL_LISTEN_HOST}:9862"
Nit: Could the new environment variable live here?
--
To view, visit http://gerrit.cloudera.org:8080/18931
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd82967cdab7b222e5876936f39e5198ba9773ea
Gerrit-Change-Number: 18931
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Sep 2022 21:37:44 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9448: Use Ozone TDE in minicluster
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18931 )
Change subject: IMPALA-9448: Use Ozone TDE in minicluster
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8541/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/18931
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd82967cdab7b222e5876936f39e5198ba9773ea
Gerrit-Change-Number: 18931
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Sep 2022 18:00:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9448: Use Ozone TDE in minicluster
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18931 )
Change subject: IMPALA-9448: Use Ozone TDE in minicluster
......................................................................
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18931
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd82967cdab7b222e5876936f39e5198ba9773ea
Gerrit-Change-Number: 18931
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 Sep 2022 02:37:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9448: Use Ozone TDE in minicluster
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18931 )
Change subject: IMPALA-9448: Use Ozone TDE in minicluster
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11319/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18931
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd82967cdab7b222e5876936f39e5198ba9773ea
Gerrit-Change-Number: 18931
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Sep 2022 22:03:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9448: Use Ozone TDE in minicluster
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18931 )
Change subject: IMPALA-9448: Use Ozone TDE in minicluster
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8551/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18931
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd82967cdab7b222e5876936f39e5198ba9773ea
Gerrit-Change-Number: 18931
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Sep 2022 21:51:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9448: Use Ozone TDE in minicluster
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18931 )
Change subject: IMPALA-9448: Use Ozone TDE in minicluster
......................................................................
Patch Set 2:
> (1 comment)
>
> > Patch Set 2:
> >
> > So, is the plan for the Ozone tests to always run on an encrypted
> bucket?
>
> I haven't seen a reason to avoid it. Although it could make sense
> to have a flag to turn it off.
I think it would be useful to have a flag that controls whether to use encryption. It is fine for it to default to on, and we may not have a test configuration where we run with it disabled. I'm thinking that it is nice to have a reminder that Ozone has encryption enabled. (But I could also see skipping it.)
--
To view, visit http://gerrit.cloudera.org:8080/18931
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd82967cdab7b222e5876936f39e5198ba9773ea
Gerrit-Change-Number: 18931
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Sep 2022 23:28:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9448: Use Ozone TDE in minicluster
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18931
to look at the new patch set (#4).
Change subject: IMPALA-9448: Use Ozone TDE in minicluster
......................................................................
IMPALA-9448: Use Ozone TDE in minicluster
Enables Ozone's Transparent Data Encryption when creating a bucket in
the minicluster. Requires `-format` to turn on encryption in an existing
minicluster.
Tested by running e2e and custom cluster tests with Ozone.
Change-Id: Icd82967cdab7b222e5876936f39e5198ba9773ea
---
M bin/impala-config.sh
M testdata/bin/run-all.sh
A testdata/bin/setup-dfs-keys.sh
M testdata/bin/setup-hdfs-env.sh
M testdata/cluster/admin
5 files changed, 45 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/18931/4
--
To view, visit http://gerrit.cloudera.org:8080/18931
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icd82967cdab7b222e5876936f39e5198ba9773ea
Gerrit-Change-Number: 18931
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-9448: Use Ozone TDE in minicluster
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18931 )
Change subject: IMPALA-9448: Use Ozone TDE in minicluster
......................................................................
Patch Set 4: Code-Review+2
Great, glad to see this working!
--
To view, visit http://gerrit.cloudera.org:8080/18931
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd82967cdab7b222e5876936f39e5198ba9773ea
Gerrit-Change-Number: 18931
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Sep 2022 21:47:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9448: Use Ozone TDE in minicluster
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18931 )
Change subject: IMPALA-9448: Use Ozone TDE in minicluster
......................................................................
IMPALA-9448: Use Ozone TDE in minicluster
Enables Ozone's Transparent Data Encryption when creating a bucket in
the minicluster. Requires `-format` to turn on encryption in an existing
minicluster.
Tested by running e2e and custom cluster tests with Ozone.
Change-Id: Icd82967cdab7b222e5876936f39e5198ba9773ea
Reviewed-on: http://gerrit.cloudera.org:8080/18931
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/impala-config.sh
M testdata/bin/run-all.sh
A testdata/bin/setup-dfs-keys.sh
M testdata/bin/setup-hdfs-env.sh
M testdata/cluster/admin
5 files changed, 45 insertions(+), 13 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/18931
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Icd82967cdab7b222e5876936f39e5198ba9773ea
Gerrit-Change-Number: 18931
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-9448: Use Ozone TDE in minicluster
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18931
to look at the new patch set (#3).
Change subject: IMPALA-9448: Use Ozone TDE in minicluster
......................................................................
IMPALA-9448: Use Ozone TDE in minicluster
Enables Ozone's Transparent Data Encryption when creating a bucket in
the minicluster. Requires `-format` to turn on encryption in an existing
minicluster.
Tested by running e2e and custom cluster tests with Ozone.
Change-Id: Icd82967cdab7b222e5876936f39e5198ba9773ea
---
M bin/impala-config.sh
M testdata/bin/run-all.sh
A testdata/bin/setup-dfs-keys.sh
M testdata/bin/setup-hdfs-env.sh
M testdata/cluster/admin
5 files changed, 46 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/18931/3
--
To view, visit http://gerrit.cloudera.org:8080/18931
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icd82967cdab7b222e5876936f39e5198ba9773ea
Gerrit-Change-Number: 18931
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-9448: Use Ozone TDE in minicluster
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18931 )
Change subject: IMPALA-9448: Use Ozone TDE in minicluster
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18931/3/bin/impala-config.sh
File bin/impala-config.sh:
http://gerrit.cloudera.org:8080/#/c/18931/3/bin/impala-config.sh@660
PS3, Line 660: export OZONE_VOLUME="impala"
: export OZONE_BUCKET="base"
: export DEFAULT_FS="o3fs://${OZONE_BUCKET}.${OZONE_VOLUME}.${INTERNAL_LISTEN_HOST}:9862"
> Nit: Could the new environment variable live here?
Yeah, definitely. I'll update it. I had something else I abandoned that led me to put it lower before.
--
To view, visit http://gerrit.cloudera.org:8080/18931
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd82967cdab7b222e5876936f39e5198ba9773ea
Gerrit-Change-Number: 18931
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Sep 2022 21:40:37 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9448: Use Ozone TDE in minicluster
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18931 )
Change subject: IMPALA-9448: Use Ozone TDE in minicluster
......................................................................
Patch Set 2:
So, is the plan for the Ozone tests to always run on an encrypted bucket?
--
To view, visit http://gerrit.cloudera.org:8080/18931
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd82967cdab7b222e5876936f39e5198ba9773ea
Gerrit-Change-Number: 18931
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Sep 2022 20:43:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9448: Use Ozone TDE in minicluster
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18931 )
Change subject: IMPALA-9448: Use Ozone TDE in minicluster
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18931
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd82967cdab7b222e5876936f39e5198ba9773ea
Gerrit-Change-Number: 18931
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Sep 2022 22:48:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9448: Use Ozone TDE in minicluster
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18931 )
Change subject: IMPALA-9448: Use Ozone TDE in minicluster
......................................................................
Patch Set 1:
Ran into two failures running e2e and custom cluster tests:
- https://gerrit.cloudera.org/c/18934/
- https://issues.apache.org/jira/browse/IMPALA-10889
--
To view, visit http://gerrit.cloudera.org:8080/18931
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd82967cdab7b222e5876936f39e5198ba9773ea
Gerrit-Change-Number: 18931
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 Aug 2022 17:20:28 +0000
Gerrit-HasComments: No