You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Miklos Gergely (Jira)" <ji...@apache.org> on 2019/10/16 23:04:00 UTC
[jira] [Comment Edited] (HIVE-20256) Remove unused classes from
Hive QL
[ https://issues.apache.org/jira/browse/HIVE-20256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953254#comment-16953254 ]
Miklos Gergely edited comment on HIVE-20256 at 10/16/19 11:03 PM:
------------------------------------------------------------------
The following files are suggested for removal:
- ql/src/java/org/apache/hadoop/hive/ql/exec/NumericUDAF.java
- ql/src/java/org/apache/hadoop/hive/ql/exec/vector/AggregateDefinition.java
- ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorColumnAssignFactory.java
- ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastBytesHashUtil.java
- ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastHashMap.java
- ql/src/java/org/apache/hadoop/hive/ql/metadata/RandomDimension.java
- ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/ExprPrunerInfo.java
- ql/src/java/org/apache/hadoop/hive/ql/parse/InputSignature.java
- ql/src/java/org/apache/hadoop/hive/ql/parse/PrintOpTreeProcessor.java
- ql/src/java/org/apache/hadoop/hive/ql/parse/TezWalker.java
- ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/io/VersionCompatibleSerializer.java
- ql/src/java/org/apache/hadoop/hive/ql/plan/ExplosionDesc.java
- ql/src/java/org/apache/hadoop/hive/ql/plan/SchemaDesc.java
I've checked each and every one of them, and none of them is referenced by any [https://github.com/apache/]* projects, or any [https://github.infra.cloudera.com/]* projects. Even their name is not present at all in any file other then themselves. [~gopalv], [~vgarg] because of this I suggest not to deprecate them, but delete them directly. Please let me know what you think.
was (Author: mgergely):
The following files are suggested for removal:
- ql/src/java/org/apache/hadoop/hive/ql/exec/NumericUDAF.java
- ql/src/java/org/apache/hadoop/hive/ql/exec/vector/AggregateDefinition.java
- ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorColumnAssignFactory.java
- ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastBytesHashUtil.java
- ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastHashMap.java- ql/src/java/org/apache/hadoop/hive/ql/metadata/RandomDimension.java
- ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/ExprPrunerInfo.java
- ql/src/java/org/apache/hadoop/hive/ql/parse/InputSignature.java
- ql/src/java/org/apache/hadoop/hive/ql/parse/PrintOpTreeProcessor.java
- ql/src/java/org/apache/hadoop/hive/ql/parse/TezWalker.java
- ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/io/VersionCompatibleSerializer.java
- ql/src/java/org/apache/hadoop/hive/ql/plan/ExplosionDesc.java
- ql/src/java/org/apache/hadoop/hive/ql/plan/SchemaDesc.java
I've checked each and every one of them, and none of them is referenced by any [https://github.com/apache/]* projects, or any [https://github.infra.cloudera.com/]* projects. Even their name is not present at all in any file other then themselves. [~gopalv], [~vgarg] because of this I suggest not to deprecate them, but delete them directly. Please let me know what you think.
> Remove unused classes from Hive QL
> ----------------------------------
>
> Key: HIVE-20256
> URL: https://issues.apache.org/jira/browse/HIVE-20256
> Project: Hive
> Issue Type: Bug
> Components: Hive
> Affects Versions: 3.0.1
> Reporter: Miklos Gergely
> Assignee: Miklos Gergely
> Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-20256.01.patch, HIVE-20256.02.patch
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)