You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rojas <al...@mesosphere.io> on 2017/04/10 10:09:31 UTC
Review Request 58292: Removed unnecesary break statements in local
approver.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58292/
-----------------------------------------------------------
Review request for mesos, Adam B, Benjamin Bannier, and Neil Conway.
Repository: mesos
Description
-------
Removes `break` statements located in lines following a `return`
statement since they are effectively unreachable code, don't improve
readability nor make the code cleaner.
Diffs
-----
src/authorizer/local/authorizer.cpp e241edf4afa48d35dbbbb94d72e8e8690f5bedfc
Diff: https://reviews.apache.org/r/58292/diff/1/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 58292: Removed unnecesary break statements in local
approver.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58292/#review171511
-----------------------------------------------------------
Ship it!
Ship It!
- Adam B
On April 10, 2017, 3:09 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58292/
> -----------------------------------------------------------
>
> (Updated April 10, 2017, 3:09 a.m.)
>
>
> Review request for mesos, Adam B, Benjamin Bannier, and Neil Conway.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removes `break` statements located in lines following a `return`
> statement since they are effectively unreachable code, don't improve
> readability nor make the code cleaner.
>
>
> Diffs
> -----
>
> src/authorizer/local/authorizer.cpp e241edf4afa48d35dbbbb94d72e8e8690f5bedfc
>
>
> Diff: https://reviews.apache.org/r/58292/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>