You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/08/11 19:34:07 UTC
[GitHub] [trafficserver] bryancall opened a new pull request #7104: Don't send image/webp responses from cache to broswers that don't support it
bryancall opened a new pull request #7104:
URL: https://github.com/apache/trafficserver/pull/7104
This closes #7099
What this patch does is only use exact match with the client Accept header field and `Content-Type: image/webp` if there is a webp response in cache.
This change is also dependent on `proxy.config.http.cache.ignore_accept_mismatch` set to 0. Alternatively I can make the change independent of `proxy.config.http.cache.ignore_accept_mismatch`. Feed back it welcomed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on pull request #7104: Don't send image/webp responses from cache to broswers that don't support it
Posted by GitBox <gi...@apache.org>.
bryancall commented on pull request #7104:
URL: https://github.com/apache/trafficserver/pull/7104#issuecomment-673033046
[approve ci docs]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on pull request #7104: Don't send image/webp responses from cache to broswers that don't support it
Posted by GitBox <gi...@apache.org>.
bryancall commented on pull request #7104:
URL: https://github.com/apache/trafficserver/pull/7104#issuecomment-672544251
[approve ci docs]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall merged pull request #7104: Don't send image/webp responses from cache to broswers that don't support it
Posted by GitBox <gi...@apache.org>.
bryancall merged pull request #7104:
URL: https://github.com/apache/trafficserver/pull/7104
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on pull request #7104: Don't send image/webp responses from cache to broswers that don't support it
Posted by GitBox <gi...@apache.org>.
bryancall commented on pull request #7104:
URL: https://github.com/apache/trafficserver/pull/7104#issuecomment-674226486
Cherry picked to 9.0.x
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit commented on pull request #7104: Don't send image/webp responses from cache to broswers that don't support it
Posted by GitBox <gi...@apache.org>.
maskit commented on pull request #7104:
URL: https://github.com/apache/trafficserver/pull/7104#issuecomment-672447861
Chrome has `image/avif` and `image/apng` in its accept header. I'm not sure how much popular these formats are, but I guess similar things would happen if they were cached. We might want to handle these in the same way.
```
image/avif,image/webp,image/apng,image/*,*/*;q=0.8
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on pull request #7104: Don't send image/webp responses from cache to broswers that don't support it
Posted by GitBox <gi...@apache.org>.
bryancall commented on pull request #7104:
URL: https://github.com/apache/trafficserver/pull/7104#issuecomment-672952559
[approve ci docs]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org