You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2023/01/11 06:53:16 UTC

[GitHub] [airflow] uranusjr commented on a diff in pull request #28841: AIP-44 Initialize methods map for Internal API RPC endpoint in the method

uranusjr commented on code in PR #28841:
URL: https://github.com/apache/airflow/pull/28841#discussion_r1066630501


##########
airflow/api_internal/endpoints/rpc_api_endpoint.py:
##########
@@ -33,11 +32,17 @@ def _build_methods_map(list) -> dict:
     return {f"{func.__module__}.{func.__name__}": func for func in list}
 
 
-METHODS_MAP = _build_methods_map(
-    [
-        DagFileProcessor.update_import_errors,
-    ]
-)
+def _initialize_map() -> dict:

Review Comment:
   I think we should inline `_build_methods_map` into this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org