You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "igarashitm (via GitHub)" <gi...@apache.org> on 2023/05/24 21:08:57 UTC
[GitHub] [camel] igarashitm opened a new pull request, #10205: CAMEL-19386: Support object property on template bean
igarashitm opened a new pull request, #10205:
URL: https://github.com/apache/camel/pull/10205
# Description
Fixes: https://issues.apache.org/jira/browse/CAMEL-19386
Also fixed the annotation for `beans` property on TemplatedRouteDefinitionDeserializer and RouteTemplateDefinitionDeserializer to represent what deserializers actually supports in the generated schema
# Target
- [x] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
# Tracking
- [x] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
<!--
# *Note*: trivial changes like, typos, minor documentation fixes and other small items do not require a JIRA issue. In this case your pull request should address just this issue, without pulling in other changes.
-->
# Apache Camel coding standards and style
- [x] I checked that each commit in the pull request has a meaningful subject line and body.
<!--
If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
-->
- [x] I formatted the code using `mvn -Pformat,fastinstall install && mvn -Psourcecheck`
<!--
You can run the aforementioned command in your module so that the build auto-formats your code and the source check verifies that is complies with our coding style. This will also be verified as part of the checks and your PR may be rejected if the checkstyle does not pass.
You can learn more about the contribution guidelines at https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
Hi @grgrzybek , I believe I made it backward compatible for XML DSL for template bean `property`, while it adds `properties` to accept object property like non-template bean style. Hopefully this won't bother your current work...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10205: CAMEL-19386: Support object property on template bean
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10205:
URL: https://github.com/apache/camel/pull/10205#issuecomment-1562039740
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 1 | 1 | 2 | 0 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] igarashitm commented on pull request #10205: CAMEL-19386: Support object property on template bean
Posted by "igarashitm (via GitHub)" <gi...@apache.org>.
igarashitm commented on PR #10205:
URL: https://github.com/apache/camel/pull/10205#issuecomment-1562677288
@oscerd There shouldn't be any problem - this change fixes the schema to allow both property styles, so https://github.com/apache/camel-kamelets/issues/1475 is not mandatory after this. But I think it's still beneficial to do that and align the style with non-template bean on official Kamelets.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #10205: CAMEL-19386: Support object property on template bean
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #10205:
URL: https://github.com/apache/camel/pull/10205#issuecomment-1562678162
I'll complete the work on that side. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10205: CAMEL-19386: Support object property on template bean
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10205:
URL: https://github.com/apache/camel/pull/10205#issuecomment-1561929458
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:camel: Maintainers, please note that first-time contributors *require manual approval* for the GitHub Actions to run.
:warning: Please note that the changes on this PR may be **tested automatically** if they change components.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] igarashitm commented on pull request #10205: CAMEL-19386: Support object property on template bean
Posted by "igarashitm (via GitHub)" <gi...@apache.org>.
igarashitm commented on PR #10205:
URL: https://github.com/apache/camel/pull/10205#issuecomment-1562054431
hmm components/camel-spring-xml tests doesn't fail for me, can I look at the workflow test log?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] igarashitm merged pull request #10205: CAMEL-19386: Support object property on template bean
Posted by "igarashitm (via GitHub)" <gi...@apache.org>.
igarashitm merged PR #10205:
URL: https://github.com/apache/camel/pull/10205
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] grgrzybek commented on pull request #10205: CAMEL-19386: Support object property on template bean
Posted by "grgrzybek (via GitHub)" <gi...@apache.org>.
grgrzybek commented on PR #10205:
URL: https://github.com/apache/camel/pull/10205#issuecomment-1562374566
yes, this is what I was thinking about and it's ok:
```java
@XmlElement(name = "properties")
@XmlJavaTypeAdapter(BeanPropertiesAdapter.class)
private Map<String, Object> properties;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10205: CAMEL-19386: Support object property on template bean
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10205:
URL: https://github.com/apache/camel/pull/10205#issuecomment-1561979004
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 1 | 1 | 2 | 0 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] grgrzybek commented on pull request #10205: CAMEL-19386: Support object property on template bean
Posted by "grgrzybek (via GitHub)" <gi...@apache.org>.
grgrzybek commented on PR #10205:
URL: https://github.com/apache/camel/pull/10205#issuecomment-1562271762
I'll check this PR before noon (CEST).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] grgrzybek commented on pull request #10205: CAMEL-19386: Support object property on template bean
Posted by "grgrzybek (via GitHub)" <gi...@apache.org>.
grgrzybek commented on PR #10205:
URL: https://github.com/apache/camel/pull/10205#issuecomment-1562400854
This YAML/XML/JAXB consistency is tricky, but finally I got the PR - looks good ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org