You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@servicecomb.apache.org by GitBox <gi...@apache.org> on 2018/02/11 06:19:40 UTC
[GitHub] codecov-io commented on issue #280: [SCB-336][sc]optimize code, add GetXXXKeyEndWithSeparator func
codecov-io commented on issue #280: [SCB-336][sc]optimize code, add GetXXXKeyEndWithSeparator func
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/280#issuecomment-364725756
# [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/280?src=pr&el=h1) Report
> Merging [#280](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/280?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/cffba0d6aeef8c1da2278b137a950575a73719ec?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `50%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/280/graphs/tree.svg?height=150&width=650&token=GAaF7zrg8R&src=pr)](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/280?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #280 +/- ##
=======================================
Coverage 70.36% 70.36%
=======================================
Files 17 17
Lines 3418 3418
=======================================
Hits 2405 2405
Misses 846 846
Partials 167 167
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/280?src=pr&el=tree) | Coverage ? | |
|---|---|---|
| [server/service/instances.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/280/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2VzLmdv) | `71.11% <0%> (?)` | :arrow_up: |
| [server/service/util/microservice\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/280/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9taWNyb3NlcnZpY2VfdXRpbC5nbw==) | `74.84% <100%> (?)` | :arrow_up: |
| [server/service/util/domain\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/280/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9kb21haW5fdXRpbC5nbw==) | `71.64% <50%> (?)` | :arrow_up: |
| [server/service/tag.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/280/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv) | `75.43% <0%> (-0.59%)` | :arrow_down: |
| [server/service/rule.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/280/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvcnVsZS5nbw==) | `77.25% <0%> (+0.42%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/280?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `? = absolute <relative> (impact)`, `? = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/280?src=pr&el=footer). Last update [cffba0d...32345ba](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/280?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services