[GitHub] [arrow] mapleFU commented on a diff in pull request #35347: GH-35270: [C++] Use Buffer instead of raw buffer in hash join internals

["mapleFU (via GitHub)" <gi...@apache.org>]

mapleFU commented on code in PR #35347:
URL: https://github.com/apache/arrow/pull/35347#discussion_r1186671345


##########
cpp/src/arrow/compute/key_map.h:
##########
@@ -226,12 +228,12 @@ class ARROW_EXPORT SwissTable {
   // ---------------------------------------------------
   // * Empty bucket has value 0x80. Non-empty bucket has highest bit set to 0.
   //
-  uint8_t* blocks_;
+  std::shared_ptr<Buffer> blocks_;
 
   // Array of hashes of values inserted into slots.
   // Undefined if the corresponding slot is empty.
   // There is 64B padding at the end.

Review Comment:
   Got it, padding and aligned are different, I missed it previously. the patch LGTM



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org