You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by da...@apache.org on 2023/06/18 08:07:14 UTC
[camel] branch main updated (513a64efdd1 -> 6d29848993f)
This is an automated email from the ASF dual-hosted git repository.
davsclaus pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
from 513a64efdd1 Fix bug for https://github.com/apache/camel/pull/10400 (#10416)
new c9c555cabcb CAMEL-19373: camel-spring-rabbitmq - Fix reply timeout (#10422)
new 6d29848993f CAMEL-19373: camel-spring-rabbitmq - Fix reply timeout (#10422)
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../apache/camel/component/springrabbit/spring-rabbitmq.json | 2 +-
.../camel/component/springrabbit/SpringRabbitMQEndpoint.java | 12 +++++++-----
2 files changed, 8 insertions(+), 6 deletions(-)
[camel] 02/02: CAMEL-19373: camel-spring-rabbitmq - Fix reply timeout (#10422)
Posted by da...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
davsclaus pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
commit 6d29848993fcb24ba845568c07581dcfa7b54f3f
Author: Claus Ibsen <cl...@gmail.com>
AuthorDate: Sun Jun 18 10:07:02 2023 +0200
CAMEL-19373: camel-spring-rabbitmq - Fix reply timeout (#10422)
---
.../org/apache/camel/component/springrabbit/spring-rabbitmq.json | 2 +-
.../camel/component/springrabbit/SpringRabbitMQEndpoint.java | 7 ++++---
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/components/camel-spring-rabbitmq/src/generated/resources/org/apache/camel/component/springrabbit/spring-rabbitmq.json b/components/camel-spring-rabbitmq/src/generated/resources/org/apache/camel/component/springrabbit/spring-rabbitmq.json
index 1808b8339ec..3d1eb3d12c0 100644
--- a/components/camel-spring-rabbitmq/src/generated/resources/org/apache/camel/component/springrabbit/spring-rabbitmq.json
+++ b/components/camel-spring-rabbitmq/src/generated/resources/org/apache/camel/component/springrabbit/spring-rabbitmq.json
@@ -105,7 +105,7 @@
"retry": { "index": 27, "kind": "parameter", "displayName": "Retry", "group": "consumer (advanced)", "label": "consumer,advanced", "required": false, "type": "object", "javaType": "org.springframework.retry.interceptor.RetryOperationsInterceptor", "deprecated": false, "autowired": false, "secret": false, "description": "Custom retry configuration to use. If this is configured then the other settings such as maximumRetryAttempts for retry are not in use." },
"confirm": { "index": 28, "kind": "parameter", "displayName": "Confirm", "group": "producer", "label": "producer", "required": false, "type": "string", "javaType": "java.lang.String", "enum": [ "auto", "enabled", "disabled" ], "deprecated": false, "autowired": false, "secret": false, "defaultValue": "auto", "description": "Controls whether to wait for confirms. The connection factory must be configured for publisher confirms and this method. auto = Camel detects if the connection fac [...]
"confirmTimeout": { "index": 29, "kind": "parameter", "displayName": "Confirm Timeout", "group": "producer", "label": "producer", "required": false, "type": "duration", "javaType": "long", "deprecated": false, "autowired": false, "secret": false, "defaultValue": "5000", "description": "Specify the timeout in milliseconds to be used when waiting for a message sent to be confirmed by RabbitMQ when doing send only messaging (InOnly). The default value is 5 seconds. A negative value indi [...]
- "replyTimeout": { "index": 30, "kind": "parameter", "displayName": "Reply Timeout", "group": "producer", "label": "producer", "required": false, "type": "duration", "javaType": "long", "deprecated": false, "autowired": false, "secret": false, "defaultValue": "5000", "description": "Specify the timeout in milliseconds to be used when waiting for a reply message when doing request\/reply (InOut) messaging. The default value is 5 seconds. A negative value indicates an indefinite timeout." },
+ "replyTimeout": { "index": 30, "kind": "parameter", "displayName": "Reply Timeout", "group": "producer", "label": "producer", "required": false, "type": "duration", "javaType": "long", "deprecated": false, "autowired": false, "secret": false, "defaultValue": "30000", "description": "Specify the timeout in milliseconds to be used when waiting for a reply message when doing request\/reply (InOut) messaging. The default value is 30 seconds. A negative value indicates an indefinite timeo [...]
"usePublisherConnection": { "index": 31, "kind": "parameter", "displayName": "Use Publisher Connection", "group": "producer", "label": "producer", "required": false, "type": "boolean", "javaType": "boolean", "deprecated": false, "autowired": false, "secret": false, "defaultValue": false, "description": "Use a separate connection for publishers and consumers" },
"lazyStartProducer": { "index": 32, "kind": "parameter", "displayName": "Lazy Start Producer", "group": "producer (advanced)", "label": "producer,advanced", "required": false, "type": "boolean", "javaType": "boolean", "deprecated": false, "autowired": false, "secret": false, "defaultValue": false, "description": "Whether the producer should be started lazy (on the first message). By starting lazy you can use this to allow CamelContext and routes to startup in situations where a produ [...]
"args": { "index": 33, "kind": "parameter", "displayName": "Args", "group": "advanced", "label": "advanced", "required": false, "type": "object", "javaType": "java.util.Map<java.lang.String, java.lang.Object>", "prefix": "arg.", "multiValue": true, "deprecated": false, "autowired": false, "secret": false, "description": "Specify arguments for configuring the different RabbitMQ concepts, a different prefix is required for each element: arg.consumer. arg.exchange. arg.queue. arg.bindin [...]
diff --git a/components/camel-spring-rabbitmq/src/main/java/org/apache/camel/component/springrabbit/SpringRabbitMQEndpoint.java b/components/camel-spring-rabbitmq/src/main/java/org/apache/camel/component/springrabbit/SpringRabbitMQEndpoint.java
index 4c7cadf9611..ed5a028104d 100644
--- a/components/camel-spring-rabbitmq/src/main/java/org/apache/camel/component/springrabbit/SpringRabbitMQEndpoint.java
+++ b/components/camel-spring-rabbitmq/src/main/java/org/apache/camel/component/springrabbit/SpringRabbitMQEndpoint.java
@@ -146,10 +146,10 @@ public class SpringRabbitMQEndpoint extends DefaultEndpoint implements AsyncEndp
+ " handles the reply message. You can also use this option if you want to use Camel as a proxy between different"
+ " message brokers and you want to route message from one system to another.")
private boolean disableReplyTo;
- @UriParam(label = "producer", javaType = "java.time.Duration", defaultValue = "5000",
+ @UriParam(label = "producer", javaType = "java.time.Duration", defaultValue = "30000",
description = "Specify the timeout in milliseconds to be used when waiting for a reply message when doing request/reply (InOut) messaging."
- + " The default value is 5 seconds. A negative value indicates an indefinite timeout.")
- private long replyTimeout = 5000;
+ + " The default value is 30 seconds. A negative value indicates an indefinite timeout (Beware that this will cause a memory leak if a reply is not received).")
+ private long replyTimeout = 30000;
@UriParam(label = "producer", javaType = "java.time.Duration", defaultValue = "5000",
description = "Specify the timeout in milliseconds to be used when waiting for a message sent to be confirmed by RabbitMQ when doing send only messaging (InOnly)."
+ " The default value is 5 seconds. A negative value indicates an indefinite timeout.")
@@ -552,6 +552,7 @@ public class SpringRabbitMQEndpoint extends DefaultEndpoint implements AsyncEndp
template.setRoutingKey(routingKey);
template.setUsePublisherConnection(usePublisherConnection);
AsyncRabbitTemplate asyncTemplate = new AsyncRabbitTemplate(template);
+ // use receive timeout (for reply timeout) on the async template
asyncTemplate.setReceiveTimeout(replyTimeout);
return asyncTemplate;
}
[camel] 01/02: CAMEL-19373: camel-spring-rabbitmq - Fix reply timeout (#10422)
Posted by da...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
davsclaus pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
commit c9c555cabcb6ec1d4e67aafdbf75002673d758bf
Author: Steven Dürrenmatt <46...@users.noreply.github.com>
AuthorDate: Sun Jun 18 10:02:42 2023 +0200
CAMEL-19373: camel-spring-rabbitmq - Fix reply timeout (#10422)
---
.../apache/camel/component/springrabbit/SpringRabbitMQEndpoint.java | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/components/camel-spring-rabbitmq/src/main/java/org/apache/camel/component/springrabbit/SpringRabbitMQEndpoint.java b/components/camel-spring-rabbitmq/src/main/java/org/apache/camel/component/springrabbit/SpringRabbitMQEndpoint.java
index 25304e0d215..4c7cadf9611 100644
--- a/components/camel-spring-rabbitmq/src/main/java/org/apache/camel/component/springrabbit/SpringRabbitMQEndpoint.java
+++ b/components/camel-spring-rabbitmq/src/main/java/org/apache/camel/component/springrabbit/SpringRabbitMQEndpoint.java
@@ -550,9 +550,10 @@ public class SpringRabbitMQEndpoint extends DefaultEndpoint implements AsyncEndp
public AsyncRabbitTemplate createInOutTemplate() {
RabbitTemplate template = new RabbitTemplate(getConnectionFactory());
template.setRoutingKey(routingKey);
- template.setReplyTimeout(replyTimeout);
template.setUsePublisherConnection(usePublisherConnection);
- return new AsyncRabbitTemplate(template);
+ AsyncRabbitTemplate asyncTemplate = new AsyncRabbitTemplate(template);
+ asyncTemplate.setReceiveTimeout(replyTimeout);
+ return asyncTemplate;
}
public AbstractMessageListenerContainer createMessageListenerContainer() {