You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "turing85 (via GitHub)" <gi...@apache.org> on 2023/10/31 12:15:08 UTC
[PR] Register To*Stream classes for reflection [camel-quarkus]
turing85 opened a new pull request, #5477:
URL: https://github.com/apache/camel-quarkus/pull/5477
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Register To*Stream classes for reflection [camel-quarkus]
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on code in PR #5477:
URL: https://github.com/apache/camel-quarkus/pull/5477#discussion_r1377768784
##########
extensions-support/xalan/deployment/src/main/java/org/apache/camel/quarkus/support/xalan/deployment/XalanNativeImageProcessor.java:
##########
Review Comment:
@turing85 Is it possible to add some tests for `To*Stream` ? so we can see these reflection are work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Register To*Stream classes for reflection [camel-quarkus]
Posted by "turing85 (via GitHub)" <gi...@apache.org>.
turing85 commented on code in PR #5477:
URL: https://github.com/apache/camel-quarkus/pull/5477#discussion_r1377837053
##########
extensions-support/xalan/deployment/src/main/java/org/apache/camel/quarkus/support/xalan/deployment/XalanNativeImageProcessor.java:
##########
Review Comment:
@zhfeng not easily, no. I know that I have an application that triggers this case. I do not know, however, what part of the application is responsible for the classes to be used. And I cannot share the application I have.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Register To*Stream classes for reflection [camel-quarkus]
Posted by "turing85 (via GitHub)" <gi...@apache.org>.
turing85 commented on code in PR #5477:
URL: https://github.com/apache/camel-quarkus/pull/5477#discussion_r1379057017
##########
extensions-support/xalan/deployment/src/main/java/org/apache/camel/quarkus/support/xalan/deployment/XalanNativeImageProcessor.java:
##########
Review Comment:
Adding a `<xsl:message>foo</xsl:message>` does not trigger it either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Register To*Stream classes for reflection [camel-quarkus]
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on code in PR #5477:
URL: https://github.com/apache/camel-quarkus/pull/5477#discussion_r1378421588
##########
extensions-support/xalan/deployment/src/main/java/org/apache/camel/quarkus/support/xalan/deployment/XalanNativeImageProcessor.java:
##########
Review Comment:
@turing85 I see. And is there any `<xsl:message>` to write some output XML contents? I try to debug the XSLT compiler and it seems that in this case, `ToXMLStream` is used in the generated translet class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Register To*Stream classes for reflection [camel-quarkus]
Posted by "turing85 (via GitHub)" <gi...@apache.org>.
turing85 commented on code in PR #5477:
URL: https://github.com/apache/camel-quarkus/pull/5477#discussion_r1378564251
##########
extensions-support/xalan/deployment/src/main/java/org/apache/camel/quarkus/support/xalan/deployment/XalanNativeImageProcessor.java:
##########
Review Comment:
Hmm... would have to check. I am not sure whether there is an output. I was able to trigger the classes yesterday with transformations setting an explicit `<xsl:output... />`, but this alone did not trigger the error. I can say that the application having this error uses custom extension functions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Register To*Stream classes for reflection [camel-quarkus]
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on code in PR #5477:
URL: https://github.com/apache/camel-quarkus/pull/5477#discussion_r1379063003
##########
extensions-support/xalan/deployment/src/main/java/org/apache/camel/quarkus/support/xalan/deployment/XalanNativeImageProcessor.java:
##########
Review Comment:
It might write some XML content, like `<xsl:message><test>foo</test></xsl:message>`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Register To*Stream classes for reflection [camel-quarkus]
Posted by "turing85 (via GitHub)" <gi...@apache.org>.
turing85 commented on code in PR #5477:
URL: https://github.com/apache/camel-quarkus/pull/5477#discussion_r1379066444
##########
extensions-support/xalan/deployment/src/main/java/org/apache/camel/quarkus/support/xalan/deployment/XalanNativeImageProcessor.java:
##########
Review Comment:
hmm.... let me test...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Register To*Stream classes for reflection [camel-quarkus]
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on code in PR #5477:
URL: https://github.com/apache/camel-quarkus/pull/5477#discussion_r1379528239
##########
extensions-support/xalan/deployment/src/main/java/org/apache/camel/quarkus/support/xalan/deployment/XalanNativeImageProcessor.java:
##########
Review Comment:
OK. I will merge this PR and maybe find a test later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Register To*Stream classes for reflection [camel-quarkus]
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng merged PR #5477:
URL: https://github.com/apache/camel-quarkus/pull/5477
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Register To*Stream classes for reflection [camel-quarkus]
Posted by "turing85 (via GitHub)" <gi...@apache.org>.
turing85 commented on code in PR #5477:
URL: https://github.com/apache/camel-quarkus/pull/5477#discussion_r1379073138
##########
extensions-support/xalan/deployment/src/main/java/org/apache/camel/quarkus/support/xalan/deployment/XalanNativeImageProcessor.java:
##########
Review Comment:
Nope. No change. Still works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Register To*Stream classes for reflection [camel-quarkus]
Posted by "turing85 (via GitHub)" <gi...@apache.org>.
turing85 commented on code in PR #5477:
URL: https://github.com/apache/camel-quarkus/pull/5477#discussion_r1378564251
##########
extensions-support/xalan/deployment/src/main/java/org/apache/camel/quarkus/support/xalan/deployment/XalanNativeImageProcessor.java:
##########
Review Comment:
Hmm... would have to check. I am not sure whether there is a message. I was able to trigger the classes yesterday with transformations setting an explicit `<xsl:output... />`, but this alone did not trigger the error. I can say that the application having this error uses custom extension functions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org