You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/11 09:08:46 UTC
[GitHub] [flink] dawidwys opened a new pull request #17447: [hotfix] Update release notes with changes to StreamStatus
dawidwys opened a new pull request #17447:
URL: https://github.com/apache/flink/pull/17447
There are two commits. First syncs the zh version with the en version. The other one adds the changes about `StreamStatus`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on a change in pull request #17447: [hotfix] Update release notes with changes to StreamStatus
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #17447:
URL: https://github.com/apache/flink/pull/17447#discussion_r729113800
##########
File path: docs/content.zh/release-notes/flink-1.14.md
##########
@@ -201,6 +201,19 @@ applications do not interfere with each other.
### DataStream API
+#### Fixed idleness handling for two/multi input operators
+
+##### [FLINK-18934](https://issues.apache.org/jira/browse/FLINK-18934)
+
+##### [FLINK-23767](https://issues.apache.org/jira/browse/FLINK-23767)
+
+We added `processWatermarkStatusX` method to classes such as `AbstractStreamOperator`, `Input` etc.
+It allows to take the `WatermarkStatus` into account when combining watermarks in two/multi input
+operators.
+
+Moreover, we clarified the contract of semi-internal, semi-public `StreamStatus` class and renamed
+it to `WatermarkStatus` in order to better reflect its purpose.
Review comment:
```suggestion
Note that with this release, we renamed the previously internal `StreamStatus` to `WatermarkStatus` in order to better reflect its purpose.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17447: [hotfix] Update release notes with changes to StreamStatus
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17447:
URL: https://github.com/apache/flink/pull/17447#issuecomment-939843106
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6c4a511b24a739610413e46fdb1617971179f1b5",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24942",
"triggerID" : "6c4a511b24a739610413e46fdb1617971179f1b5",
"triggerType" : "PUSH"
}, {
"hash" : "6c4a511b24a739610413e46fdb1617971179f1b5",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24942",
"triggerID" : "940886720",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 6c4a511b24a739610413e46fdb1617971179f1b5 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24942)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17447: [hotfix] Update release notes with changes to StreamStatus
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17447:
URL: https://github.com/apache/flink/pull/17447#issuecomment-939843106
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6c4a511b24a739610413e46fdb1617971179f1b5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6c4a511b24a739610413e46fdb1617971179f1b5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6c4a511b24a739610413e46fdb1617971179f1b5 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on a change in pull request #17447: [hotfix] Update release notes with changes to StreamStatus
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #17447:
URL: https://github.com/apache/flink/pull/17447#discussion_r727055948
##########
File path: docs/content.zh/release-notes/flink-1.14.md
##########
@@ -201,6 +201,19 @@ applications do not interfere with each other.
### DataStream API
+#### Fixed idleness handling for two/multi input operators
+
+##### [FLINK-18934](https://issues.apache.org/jira/browse/FLINK-18934)
+
+##### [FLINK-23767](https://issues.apache.org/jira/browse/FLINK-23767)
+
+We added `processWatermarkStatusX` method to classes such as `AbstractStreamOperator`, `Input` etc.
+It allows to take the `WatermarkStatus` into account when combining watermarks in two/multi input
+operators.
+
+Moreover, we clarified the contract of semi-internal, semi-public `StreamStatus` class and renamed
+it to `WatermarkStatus` in order to better reflect its purpose.
Review comment:
1. Why `WatermarkStatus` is marked `@Internal` if it's used in `@PublicEvolving` and `@Experimental` classes?
2. "semi-internal, semi-public" sounds very unprofessional. I would just skip this part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on pull request #17447: [hotfix] Update release notes with changes to StreamStatus
Posted by GitBox <gi...@apache.org>.
dawidwys commented on pull request #17447:
URL: https://github.com/apache/flink/pull/17447#issuecomment-940886720
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17447: [hotfix] Update release notes with changes to StreamStatus
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17447:
URL: https://github.com/apache/flink/pull/17447#issuecomment-939843106
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6c4a511b24a739610413e46fdb1617971179f1b5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24942",
"triggerID" : "6c4a511b24a739610413e46fdb1617971179f1b5",
"triggerType" : "PUSH"
}, {
"hash" : "6c4a511b24a739610413e46fdb1617971179f1b5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24942",
"triggerID" : "940886720",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 6c4a511b24a739610413e46fdb1617971179f1b5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24942)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17447: [hotfix] Update release notes with changes to StreamStatus
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17447:
URL: https://github.com/apache/flink/pull/17447#issuecomment-939843106
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6c4a511b24a739610413e46fdb1617971179f1b5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24942",
"triggerID" : "6c4a511b24a739610413e46fdb1617971179f1b5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6c4a511b24a739610413e46fdb1617971179f1b5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24942)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys closed pull request #17447: [hotfix] Update release notes with changes to StreamStatus
Posted by GitBox <gi...@apache.org>.
dawidwys closed pull request #17447:
URL: https://github.com/apache/flink/pull/17447
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17447: [hotfix] Update release notes with changes to StreamStatus
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17447:
URL: https://github.com/apache/flink/pull/17447#issuecomment-939843106
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6c4a511b24a739610413e46fdb1617971179f1b5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24942",
"triggerID" : "6c4a511b24a739610413e46fdb1617971179f1b5",
"triggerType" : "PUSH"
}, {
"hash" : "6c4a511b24a739610413e46fdb1617971179f1b5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24942",
"triggerID" : "940886720",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 6c4a511b24a739610413e46fdb1617971179f1b5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24942)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17447: [hotfix] Update release notes with changes to StreamStatus
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17447:
URL: https://github.com/apache/flink/pull/17447#issuecomment-939840375
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 6c4a511b24a739610413e46fdb1617971179f1b5 (Mon Oct 11 09:12:33 UTC 2021)
✅no warnings
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on a change in pull request #17447: [hotfix] Update release notes with changes to StreamStatus
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #17447:
URL: https://github.com/apache/flink/pull/17447#discussion_r729113800
##########
File path: docs/content.zh/release-notes/flink-1.14.md
##########
@@ -201,6 +201,19 @@ applications do not interfere with each other.
### DataStream API
+#### Fixed idleness handling for two/multi input operators
+
+##### [FLINK-18934](https://issues.apache.org/jira/browse/FLINK-18934)
+
+##### [FLINK-23767](https://issues.apache.org/jira/browse/FLINK-23767)
+
+We added `processWatermarkStatusX` method to classes such as `AbstractStreamOperator`, `Input` etc.
+It allows to take the `WatermarkStatus` into account when combining watermarks in two/multi input
+operators.
+
+Moreover, we clarified the contract of semi-internal, semi-public `StreamStatus` class and renamed
+it to `WatermarkStatus` in order to better reflect its purpose.
Review comment:
```suggestion
We added `processWatermarkStatusX` method to classes such as `AbstractStreamOperator`, `Input` etc.
It allows to take the `WatermarkStatus` into account when combining watermarks in two/multi input
operators. Note that with this release, we renamed `StreamStatus` to `WatermarkStatus` in order to better reflect its purpose.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17447: [hotfix] Update release notes with changes to StreamStatus
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17447:
URL: https://github.com/apache/flink/pull/17447#issuecomment-939843106
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6c4a511b24a739610413e46fdb1617971179f1b5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24942",
"triggerID" : "6c4a511b24a739610413e46fdb1617971179f1b5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6c4a511b24a739610413e46fdb1617971179f1b5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24942)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on a change in pull request #17447: [hotfix] Update release notes with changes to StreamStatus
Posted by GitBox <gi...@apache.org>.
dawidwys commented on a change in pull request #17447:
URL: https://github.com/apache/flink/pull/17447#discussion_r727097686
##########
File path: docs/content.zh/release-notes/flink-1.14.md
##########
@@ -201,6 +201,19 @@ applications do not interfere with each other.
### DataStream API
+#### Fixed idleness handling for two/multi input operators
+
+##### [FLINK-18934](https://issues.apache.org/jira/browse/FLINK-18934)
+
+##### [FLINK-23767](https://issues.apache.org/jira/browse/FLINK-23767)
+
+We added `processWatermarkStatusX` method to classes such as `AbstractStreamOperator`, `Input` etc.
+It allows to take the `WatermarkStatus` into account when combining watermarks in two/multi input
+operators.
+
+Moreover, we clarified the contract of semi-internal, semi-public `StreamStatus` class and renamed
+it to `WatermarkStatus` in order to better reflect its purpose.
Review comment:
Ad. 1 See point 2.
Ad. 2 See point 1.
;P
Honestly, I don't mind a tiny bit of being unprofessional, but sure, let me remove the phrase ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org