You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2016/04/27 10:30:28 UTC
svn commit: r1741159 -
/tomcat/trunk/java/org/apache/catalina/authenticator/SingleSignOnEntry.java
Author: markt
Date: Wed Apr 27 08:30:28 2016
New Revision: 1741159
URL: http://svn.apache.org/viewvc?rev=1741159&view=rev
Log:
Review of Map / ConcurrentMap / ConcurrentHashMap
Simplify. sessionKeys is only used internally so it can be declared as Map with Java 8.
Also:
- Reduce visibility of fields.
- Use final where possible.
Modified:
tomcat/trunk/java/org/apache/catalina/authenticator/SingleSignOnEntry.java
Modified: tomcat/trunk/java/org/apache/catalina/authenticator/SingleSignOnEntry.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/authenticator/SingleSignOnEntry.java?rev=1741159&r1=1741158&r2=1741159&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/authenticator/SingleSignOnEntry.java (original)
+++ tomcat/trunk/java/org/apache/catalina/authenticator/SingleSignOnEntry.java Wed Apr 27 08:30:28 2016
@@ -21,6 +21,7 @@ import java.io.ObjectInputStream;
import java.io.ObjectOutputStream;
import java.io.Serializable;
import java.security.Principal;
+import java.util.Map;
import java.util.Set;
import java.util.concurrent.ConcurrentHashMap;
@@ -45,19 +46,19 @@ public class SingleSignOnEntry implement
// ------------------------------------------------------ Instance Fields
- protected String authType = null;
+ private String authType = null;
- protected String password = null;
+ private String password = null;
// Marked as transient so special handling can be applied to serialization
- protected transient Principal principal = null;
+ private transient Principal principal = null;
- protected ConcurrentHashMap<SingleSignOnSessionKey,SingleSignOnSessionKey> sessionKeys =
+ private final Map<SingleSignOnSessionKey,SingleSignOnSessionKey> sessionKeys =
new ConcurrentHashMap<>();
- protected String username = null;
+ private String username = null;
- protected boolean canReauthenticate = false;
+ private boolean canReauthenticate = false;
// --------------------------------------------------------- Constructors
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org