[jira] [Comment Edited] (SLING-10110) Sling Dynamic Include: ignoreUrlParams with Wildcards do not work

["Andreas Bannasch (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-10110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17634899#comment-17634899 ] 

Andreas Bannasch edited comment on SLING-10110 at 11/16/22 3:50 PM:
--------------------------------------------------------------------

I tried to add the functionality myself and wrote Unit-Tests to make sure the existing and new logic work properly.
I'm not entirely sure if it will work as I used the Stream-API that was introduced in Java8 and i'm not sure that the project is above Java7

[~rombert] Should i push my local branch and create a Pull-Request?


was (Author: songlesshill):
I tried to add the functionality myself and wrote Unit-Tests to make sure the existing and new logic work properly.

[~rombert] Should i push my local branch and create a Pull-Request?

> Sling Dynamic Include: ignoreUrlParams with Wildcards do not work
> -----------------------------------------------------------------
>
>                 Key: SLING-10110
>                 URL: https://issues.apache.org/jira/browse/SLING-10110
>             Project: Sling
>          Issue Type: Bug
>    Affects Versions: Dynamic Include 3.2.0
>         Environment: AEM 6.3 - AEM 6.5
>            Reporter: Andreas Bannasch
>            Priority: Major
>             Fix For: Dynamic Include 3.3.2
>
>
> Hello
> i have the following problem in my AEM instance but i think it might be a general problem.
> The issue i am facing is that in my dispatcher configuration there are several parameters defined with a * as wildcard.
> This is configured for our tracking engine where users might get a link to a page with one of these parameters.
> For example:
> {code:html}
> https//www.mypage.com/latest-news?testengine-usergroup=10
> {code}
> In this case my dispatcher is configured to ignore the paramers that match the following:
> {code:html}
> testengine-*
> {code}
> When i configured this in my SlingDynamicInclude config on the server under the ignoreUrlParams it does not see the above parameter from the url as matching for ignoreUrlParams.
>  
> {code:config}
> include-filter.config.extension=""
> include-filter.config.enabled=B"true"
> include-filter.config.path="/content"
> include-filter.config.required_header="Server-Agent\=Communique-Dispatcher"
> include-filter.config.include-type="SSI"
> include-filter.config.selector="nocache"
> include-filter.config.add_comment=B"true"
> include-filter.config.appendSuffix=B"true"
> include-filter.config.rewrite=B"false"
> include-filter.config.ttl=""
> # These are the urlParams from the dispatcher that are ignored by as such and will load from cache (for tracking etc.)
> # If you do not ignore them then a page with rendered SDI will be cached if the call contains these parameters
> include-filter.config.ignoreUrlParams=[
>     "gclid",
>     "testengine-*"
> ]
> include-filter.config.resource-types=[
>     "mypage/components/slingdynamic/dynamicbanner"
> ]
> {code}
> Instead the SDI component will completely render and since my dispatcher was configured to ignore this parameter, the response will be cached with an already rendered SDI-Component instead of the SDI-Tag.
> I hope this information is enough to understand what my problem is.
> If there are some more informations that you need or if something is not clear enough please tell me and i will try to update everything that is needed



--
This message was sent by Atlassian Jira
(v8.20.10#820010)