You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/05/20 13:02:43 UTC

[GitHub] [tvm] tqchen commented on pull request #8090: [WIP] Just want use official CI to verify idea.

tqchen commented on pull request #8090:
URL: https://github.com/apache/tvm/pull/8090#issuecomment-845098489


   Please avoid using CI for just verifications purposes, since CI is a resource shared by the community for code contribution gatting, since we always recommend testing things locally before sending the PR and write unit-test cases for the related change. 
   
   I can see the proposed set of changes, the particular logic of mul mod merging can likely be removed in most settings where the offset are constant(as in your case), because canonical simplifier covers that. 
   
   It is a bit unclear whether we can safely remove in settings when shape are symbolic. Constructing unit-test cases would be a good way to explore the problem
   
   Thank you!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org