You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/02/04 23:31:20 UTC
[GitHub] [bookkeeper] nicoloboschi opened a new pull request #3027: [ci] Move CI to JDK11
nicoloboschi opened a new pull request #3027:
URL: https://github.com/apache/bookkeeper/pull/3027
### Motivation
BookKeeper runs with JDK11 since a long ago. The official docker image is using JDK11 so it's much better to verify the codebase using JDK11
### Changes
* Update all the checks to using jdk11 temurin distro
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] nicoloboschi commented on pull request #3027: [ci] Move CI to JDK11
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on pull request #3027:
URL: https://github.com/apache/bookkeeper/pull/3027#issuecomment-1040558207
The matrix add a significant overhead for every pull request since the tests execution is doubled.
I don't see any relevant motivation to keep the entire CI with both the jdk's.
I left a couple of jobs using JDK8, they ensure JDK8 compile compatibility.
Also, from a mid-term perspective, when we will upgrade to JDK 17 (or next TLS) it's not a good idea to duplicate the CI jobs another time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] nicoloboschi commented on pull request #3027: [ci] Move CI to JDK11
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on pull request #3027:
URL: https://github.com/apache/bookkeeper/pull/3027#issuecomment-1048848572
@dlg99 I think we could merge this before the release branch creation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] nicoloboschi commented on pull request #3027: [ci] Move CI to JDK11
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on pull request #3027:
URL: https://github.com/apache/bookkeeper/pull/3027#issuecomment-1038994682
@eolivelli @dlg99 @merlimat PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] nicoloboschi commented on pull request #3027: [ci] Move CI to JDK11
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on pull request #3027:
URL: https://github.com/apache/bookkeeper/pull/3027#issuecomment-1040558207
The matrix add a significant overhead for every pull request since the tests execution is doubled.
I don't see any relevant motivation to keep the entire CI with both the jdk's.
I left a couple of jobs using JDK8, they ensure JDK8 compile compatibility.
Also, from a mid-term perspective, when we will upgrade to JDK 17 (or next TLS) it's not a good idea to duplicate the CI jobs another time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] nicoloboschi commented on pull request #3027: [ci] Move CI to JDK11
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on pull request #3027:
URL: https://github.com/apache/bookkeeper/pull/3027#issuecomment-1033043944
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] zymap commented on pull request #3027: [ci] Move CI to JDK11
Posted by GitBox <gi...@apache.org>.
zymap commented on pull request #3027:
URL: https://github.com/apache/bookkeeper/pull/3027#issuecomment-1040044284
Can we use a matrix to run both the jdk1.8 and jdk11?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] zymap commented on pull request #3027: [ci] Move CI to JDK11
Posted by GitBox <gi...@apache.org>.
zymap commented on pull request #3027:
URL: https://github.com/apache/bookkeeper/pull/3027#issuecomment-1040044284
Can we use a matrix to run both the jdk1.8 and jdk11?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] nicoloboschi commented on pull request #3027: [ci] Move CI to JDK11
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on pull request #3027:
URL: https://github.com/apache/bookkeeper/pull/3027#issuecomment-1038932764
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] nicoloboschi commented on pull request #3027: [ci] Move CI to JDK11
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on pull request #3027:
URL: https://github.com/apache/bookkeeper/pull/3027#issuecomment-1035256125
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] nicoloboschi commented on pull request #3027: [ci] Move CI to JDK11
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on pull request #3027:
URL: https://github.com/apache/bookkeeper/pull/3027#issuecomment-1034365890
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] nicoloboschi commented on pull request #3027: [ci] Move CI to JDK11
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on pull request #3027:
URL: https://github.com/apache/bookkeeper/pull/3027#issuecomment-1034181977
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli merged pull request #3027: [ci] Move CI to JDK11
Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #3027:
URL: https://github.com/apache/bookkeeper/pull/3027
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] nicoloboschi edited a comment on pull request #3027: [ci] Move CI to JDK11
Posted by GitBox <gi...@apache.org>.
nicoloboschi edited a comment on pull request #3027:
URL: https://github.com/apache/bookkeeper/pull/3027#issuecomment-1040558207
The matrix adds a significant overhead for every pull request since the tests execution is doubled.
I don't see any relevant motivation to keep the entire CI with both the jdk's.
I left a couple of jobs using JDK8, they ensure JDK8 compile compatibility.
Also, from a mid-term perspective, when we will upgrade to JDK 17 (or next TLS) it's not a good idea to duplicate the CI jobs another time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] nicoloboschi edited a comment on pull request #3027: [ci] Move CI to JDK11
Posted by GitBox <gi...@apache.org>.
nicoloboschi edited a comment on pull request #3027:
URL: https://github.com/apache/bookkeeper/pull/3027#issuecomment-1040558207
The matrix adds a significant overhead for every pull request since the tests execution is doubled.
I don't see any relevant motivation to keep the entire CI with both the jdk's.
I left a couple of jobs using JDK8, they ensure JDK8 compile compatibility.
Also, from a mid-term perspective, when we will upgrade to JDK 17 (or next lts) it's not a good idea to duplicate the CI jobs another time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] nicoloboschi commented on pull request #3027: [ci] Move CI to JDK11
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on pull request #3027:
URL: https://github.com/apache/bookkeeper/pull/3027#issuecomment-1034281100
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org