You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/05/12 11:43:57 UTC
[GitHub] [apisix] Gary-Airwallex opened a new issue #4229: feat: append query string when using redirect with regex_uri
Gary-Airwallex opened a new issue #4229:
URL: https://github.com/apache/apisix/issues/4229
### Proposed changes
https://github.com/apache/apisix/pull/4152 supports redirect with regex, but 1. it does not append the query string from original request to the Location header, and 2. it does not encode url. I suggest fxing these as in proxy-rewrite. If everyone agrees on this I'll create a PR for the change.
### Concerns
Proposed changes do change the behavior of current implementation, and it will cause problems if
1. someone expects the query string to be removed, or
2. someone encodes url manually in plugin configuration, e.g. `"regex_uri": ["/abc(.*)", "/ab%20c$1"],`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #4229: feat: append query string when using redirect with regex_uri
Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #4229:
URL: https://github.com/apache/apisix/issues/4229#issuecomment-846848954
@Gary-Airwallex
Will you submit a PR for the first part? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on issue #4229: feat: append query string when using redirect with regex_uri
Posted by GitBox <gi...@apache.org>.
Firstsawyou commented on issue #4229:
URL: https://github.com/apache/apisix/issues/4229#issuecomment-839803749
I think this is a very good feature. For concerns, we can use a switch to decide whether to enable this feature.
@spacewander What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander closed issue #4229: feat: append query string when using redirect with regex_uri
Posted by GitBox <gi...@apache.org>.
spacewander closed issue #4229:
URL: https://github.com/apache/apisix/issues/4229
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #4229: feat: append query string when using redirect with regex_uri
Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #4229:
URL: https://github.com/apache/apisix/issues/4229#issuecomment-840227202
Yes, we can add two options for them. We can create two PRs, each for a new feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org