You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by GitBox <gi...@apache.org> on 2022/09/04 07:40:11 UTC

[GitHub] [groovy] daniellansun opened a new pull request, #1781: GROOVY-10747: Fix illegal access for object clone on JDK16+

daniellansun opened a new pull request, #1781:
URL: https://github.com/apache/groovy/pull/1781

   https://issues.apache.org/jira/browse/GROOVY-10747


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [groovy] paulk-asert commented on pull request #1781: GROOVY-10747: Fix illegal access for object clone on JDK16+

Posted by GitBox <gi...@apache.org>.
paulk-asert commented on PR #1781:
URL: https://github.com/apache/groovy/pull/1781#issuecomment-1236896656

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [groovy] daniellansun merged pull request #1781: GROOVY-10747: Fix illegal access for object clone on JDK16+

Posted by GitBox <gi...@apache.org>.
daniellansun merged PR #1781:
URL: https://github.com/apache/groovy/pull/1781


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [groovy] daniellansun commented on a diff in pull request #1781: GROOVY-10747: Fix illegal access for object clone on JDK16+

Posted by GitBox <gi...@apache.org>.
daniellansun commented on code in PR #1781:
URL: https://github.com/apache/groovy/pull/1781#discussion_r962830207


##########
src/main/java/org/codehaus/groovy/runtime/ArrayUtil.java:
##########
@@ -61,31 +55,32 @@
 public class ArrayUtil {
     private static final Object[] EMPTY = new Object[0];
 
-    public static MethodHandle getCloneArrayMethodHandle() {

Review Comment:
   `getCloneArrayMethodHandle` was added in 4.0.5-SNAPSHOT, so removing it will not break binary compatibility



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [groovy] daniellansun commented on pull request #1781: GROOVY-10747: Fix illegal access for object clone on JDK16+

Posted by GitBox <gi...@apache.org>.
daniellansun commented on PR #1781:
URL: https://github.com/apache/groovy/pull/1781#issuecomment-1236902735

   @paulk-asert Thanks for your reviewing. I'll tweak it a bit later


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org