You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/04/07 22:26:09 UTC
[GitHub] [tvm] driazati opened a new pull request, #10933: clang
driazati opened a new pull request, #10933:
URL: https://github.com/apache/tvm/pull/10933
- [ci] Don't diff when running clang-format
- format files
Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @ them in the pull request thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] driazati commented on a diff in pull request #10933: [ci] Don't diff when running clang-format
Posted by GitBox <gi...@apache.org>.
driazati commented on code in PR #10933:
URL: https://github.com/apache/tvm/pull/10933#discussion_r846437249
##########
tests/lint/clang_format.sh:
##########
@@ -1,24 +0,0 @@
-#!/usr/bin/env bash
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements. See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership. The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License. You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing,
-# software distributed under the License is distributed on an
-# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-# KIND, either express or implied. See the License for the
-# specific language governing permissions and limitations
-# under the License.
-
-set -e
-
-# check lastest change, for squash merge into main
-./tests/lint/git-clang-format.sh HEAD~1
-# chekc against origin/main for PRs.
-./tests/lint/git-clang-format.sh origin/main
Review Comment:
it only ran against the diff, these must have snuck in at some point and then they would only come up when those file names were changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on a diff in pull request #10933: [ci] Don't diff when running clang-format
Posted by GitBox <gi...@apache.org>.
areusch commented on code in PR #10933:
URL: https://github.com/apache/tvm/pull/10933#discussion_r846436631
##########
tests/lint/clang_format.sh:
##########
@@ -1,24 +0,0 @@
-#!/usr/bin/env bash
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements. See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership. The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License. You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing,
-# software distributed under the License is distributed on an
-# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-# KIND, either express or implied. See the License for the
-# specific language governing permissions and limitations
-# under the License.
-
-set -e
-
-# check lastest change, for squash merge into main
-./tests/lint/git-clang-format.sh HEAD~1
-# chekc against origin/main for PRs.
-./tests/lint/git-clang-format.sh origin/main
Review Comment:
confused, shouldn't this have caught all of these mis-formats?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on a diff in pull request #10933: [ci] Don't diff when running clang-format
Posted by GitBox <gi...@apache.org>.
areusch commented on code in PR #10933:
URL: https://github.com/apache/tvm/pull/10933#discussion_r846485647
##########
tests/lint/git-clang-format.sh:
##########
@@ -58,14 +70,21 @@ fi
# Print out specific version
${CLANG_FORMAT} --version
-if [[ ${INPLACE_FORMAT} -eq 1 ]]; then
- echo "Running inplace git-clang-format against" $1
- git-${CLANG_FORMAT} --extensions h,mm,c,cc --binary=${CLANG_FORMAT} $1
+if [[ "$INPLACE_FORMAT" == "true" ]]; then
+ echo "Running inplace git-clang-format against $REVISION"
+ git-${CLANG_FORMAT} --extensions h,mm,c,cc --binary=${CLANG_FORMAT} "$REVISION"
exit 0
fi
-echo "Running git-clang-format against" $1
-git-${CLANG_FORMAT} --diff --extensions h,mm,c,cc --binary=${CLANG_FORMAT} $1 1> /tmp/$$.clang-format.txt
+if [[ "$LINT_ALL_FILES" == "true" ]]; then
+ echo "Running git-clang-format against all C++ files"
+ FILES=$(git ls-files | grep -E '\.(c|cc|cpp|mm|h|hpp)$')
+ git-${CLANG_FORMAT} --diff --extensions h,mm,c,cc --binary=${CLANG_FORMAT} "$REVISION" ${FILES[@]} 1> /tmp/$$.clang-format.txt
Review Comment:
didn't we need "${FILES[@]}" to avoid picking up untracked changes in the working tree?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] driazati commented on pull request #10933: [ci] Don't diff when running clang-format
Posted by GitBox <gi...@apache.org>.
driazati commented on PR #10933:
URL: https://github.com/apache/tvm/pull/10933#issuecomment-1092270056
Right this should fix the issue you had earlier regarding the difference in output between CI / local
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on a diff in pull request #10933: [ci] Don't diff when running clang-format
Posted by GitBox <gi...@apache.org>.
areusch commented on code in PR #10933:
URL: https://github.com/apache/tvm/pull/10933#discussion_r846533802
##########
tests/lint/git-clang-format.sh:
##########
@@ -58,14 +70,21 @@ fi
# Print out specific version
${CLANG_FORMAT} --version
-if [[ ${INPLACE_FORMAT} -eq 1 ]]; then
- echo "Running inplace git-clang-format against" $1
- git-${CLANG_FORMAT} --extensions h,mm,c,cc --binary=${CLANG_FORMAT} $1
+if [[ "$INPLACE_FORMAT" == "true" ]]; then
+ echo "Running inplace git-clang-format against $REVISION"
+ git-${CLANG_FORMAT} --extensions h,mm,c,cc --binary=${CLANG_FORMAT} "$REVISION"
exit 0
fi
-echo "Running git-clang-format against" $1
-git-${CLANG_FORMAT} --diff --extensions h,mm,c,cc --binary=${CLANG_FORMAT} $1 1> /tmp/$$.clang-format.txt
+if [[ "$LINT_ALL_FILES" == "true" ]]; then
+ echo "Running git-clang-format against all C++ files"
+ FILES=$(git ls-files | grep -E '\.(c|cc|cpp|mm|h|hpp)$')
+ git-${CLANG_FORMAT} --diff --extensions h,mm,c,cc --binary=${CLANG_FORMAT} "$REVISION" ${FILES[@]} 1> /tmp/$$.clang-format.txt
Review Comment:
answer: no, this wasn't a problem that this PR was trying to fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] shingjan commented on pull request #10933: [ci] Don't diff when running clang-format
Posted by GitBox <gi...@apache.org>.
shingjan commented on PR #10933:
URL: https://github.com/apache/tvm/pull/10933#issuecomment-1092269534
Thanks for sending out this PR! @driazati Is this solve the similar problem with https://github.com/apache/tvm/pull/10895 but on the cpp side?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on a diff in pull request #10933: [ci] Don't diff when running clang-format
Posted by GitBox <gi...@apache.org>.
areusch commented on code in PR #10933:
URL: https://github.com/apache/tvm/pull/10933#discussion_r846460118
##########
tests/lint/git-clang-format.sh:
##########
@@ -58,14 +70,21 @@ fi
# Print out specific version
${CLANG_FORMAT} --version
-if [[ ${INPLACE_FORMAT} -eq 1 ]]; then
- echo "Running inplace git-clang-format against" $1
- git-${CLANG_FORMAT} --extensions h,mm,c,cc --binary=${CLANG_FORMAT} $1
+if [[ "$INPLACE_FORMAT" == "true" ]]; then
+ echo "Running inplace git-clang-format against $REVISION"
+ git-${CLANG_FORMAT} --extensions h,mm,c,cc --binary=${CLANG_FORMAT} "$REVISION"
exit 0
fi
-echo "Running git-clang-format against" $1
-git-${CLANG_FORMAT} --diff --extensions h,mm,c,cc --binary=${CLANG_FORMAT} $1 1> /tmp/$$.clang-format.txt
+if [[ "$LINT_ALL_FILES" == "true" ]]; then
+ echo "Running git-clang-format against all C++ files"
+ FILES=$(git ls-files | grep -E '\.(c|cc|cpp|mm|h|hpp)$')
+ git-${CLANG_FORMAT} --diff --extensions h,mm,c,cc --binary=${CLANG_FORMAT} "$REVISION" ${FILES[@]} 1> /tmp/$$.clang-format.txt
Review Comment:
nit: "${FILES[@]}", hopefully this doesn't blow up the max command-line length tho
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch merged pull request #10933: [ci] Don't diff when running clang-format
Posted by GitBox <gi...@apache.org>.
areusch merged PR #10933:
URL: https://github.com/apache/tvm/pull/10933
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on a diff in pull request #10933: [ci] Don't diff when running clang-format
Posted by GitBox <gi...@apache.org>.
areusch commented on code in PR #10933:
URL: https://github.com/apache/tvm/pull/10933#discussion_r846467532
##########
tests/lint/clang_format.sh:
##########
@@ -1,24 +0,0 @@
-#!/usr/bin/env bash
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements. See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership. The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License. You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing,
-# software distributed under the License is distributed on an
-# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-# KIND, either express or implied. See the License for the
-# specific language governing permissions and limitations
-# under the License.
-
-set -e
-
-# check lastest change, for squash merge into main
-./tests/lint/git-clang-format.sh HEAD~1
-# chekc against origin/main for PRs.
-./tests/lint/git-clang-format.sh origin/main
Review Comment:
got it, this makes more sense. reviewed more carefully now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] driazati commented on a diff in pull request #10933: [ci] Don't diff when running clang-format
Posted by GitBox <gi...@apache.org>.
driazati commented on code in PR #10933:
URL: https://github.com/apache/tvm/pull/10933#discussion_r846484193
##########
tests/lint/git-clang-format.sh:
##########
@@ -58,14 +70,21 @@ fi
# Print out specific version
${CLANG_FORMAT} --version
-if [[ ${INPLACE_FORMAT} -eq 1 ]]; then
- echo "Running inplace git-clang-format against" $1
- git-${CLANG_FORMAT} --extensions h,mm,c,cc --binary=${CLANG_FORMAT} $1
+if [[ "$INPLACE_FORMAT" == "true" ]]; then
+ echo "Running inplace git-clang-format against $REVISION"
+ git-${CLANG_FORMAT} --extensions h,mm,c,cc --binary=${CLANG_FORMAT} "$REVISION"
exit 0
fi
-echo "Running git-clang-format against" $1
-git-${CLANG_FORMAT} --diff --extensions h,mm,c,cc --binary=${CLANG_FORMAT} $1 1> /tmp/$$.clang-format.txt
+if [[ "$LINT_ALL_FILES" == "true" ]]; then
+ echo "Running git-clang-format against all C++ files"
+ FILES=$(git ls-files | grep -E '\.(c|cc|cpp|mm|h|hpp)$')
+ git-${CLANG_FORMAT} --diff --extensions h,mm,c,cc --binary=${CLANG_FORMAT} "$REVISION" ${FILES[@]} 1> /tmp/$$.clang-format.txt
Review Comment:
the quotes stop it from word splitting or something or it may be hitting some limit since I see the args are now truncated. In any case this isn't even necessary here since `git-clang-format` will pick up this list anyways since it runs with `REVISION` set to the first commit in the repo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org