[GitHub] [beam] mkhludnev commented on a diff in pull request #27329: BEAM-12877: fix avro utils for decimals etc

["mkhludnev (via GitHub)" <gi...@apache.org>]

mkhludnev commented on code in PR #27329:
URL: https://github.com/apache/beam/pull/27329#discussion_r1268536607


##########
sdks/java/extensions/avro/src/test/java/org/apache/beam/sdk/extensions/avro/schemas/utils/AvroUtilsTest.java:
##########
@@ -246,10 +247,17 @@ private static org.apache.avro.Schema getAvroSchema() {
             "bytes", org.apache.avro.Schema.create(Type.BYTES), "", (Object) null));
     fields.add(
         new org.apache.avro.Schema.Field(
-            "decimal",
-            LogicalTypes.decimal(Integer.MAX_VALUE)
-                .addToSchema(org.apache.avro.Schema.create(Type.BYTES)),
-            "",
+                "decimalBytes",

Review Comment:
   I don't like here `LogicalTypes.decimal(Integer.MAX_VALUE)` replaced to decimals with prec&scale.  I think it's worth to keep existing test unless it's wrong completely.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org