You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/05 19:47:39 UTC

[GitHub] [arrow-datafusion] andygrove commented on a diff in pull request #2457: [WIP] Fix bugs in SQL planner with GROUP BY scalar function

andygrove commented on code in PR #2457:
URL: https://github.com/apache/arrow-datafusion/pull/2457#discussion_r866259199


##########
datafusion/core/src/logical_plan/expr.rs:
##########
@@ -138,9 +138,29 @@ pub fn create_udaf(
 /// Create field meta-data from an expression, for use in a result set schema
 pub fn exprlist_to_fields<'a>(
     expr: impl IntoIterator<Item = &'a Expr>,
-    input_schema: &DFSchema,
+    plan: &LogicalPlan,

Review Comment:
   We pass in a plan instead of a schema now, which gives us more control



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org