You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2018/07/21 00:26:35 UTC

[GitHub] jacobrosenthal commented on issue #1286: Add support for the Bosch BME680 Environmental Sensor

jacobrosenthal commented on issue #1286: Add support for the Bosch BME680 Environmental Sensor
URL: https://github.com/apache/mynewt-core/pull/1286#issuecomment-406756645
 
 
   My main review would be it seems like a fine sensor, but doesnt expose any way of using it other than through the sensor read function. 
   
   Frankly, thats fair with how the current sensor system is designed but is something Im right now attempting to get some buy in to change in https://github.com/apache/mynewt-core/pull/1285. 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services