You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/30 21:21:52 UTC
[GitHub] [pulsar-client-go] pgier opened a new pull request, #856: read module version info from golang runtime
pgier opened a new pull request, #856:
URL: https://github.com/apache/pulsar-client-go/pull/856
### Motivation
Instead of maintaining a hard coded version string in the sources, we can get the version of the pulsar-client-go module used to build the client application.
### Modifications
Removed the hard coded version string and replaced it with code that runs at initialization to look up the version of the client golang module dependency that was used to build the app.
### Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] pgier commented on pull request #856: read module version info from golang runtime
Posted by GitBox <gi...@apache.org>.
pgier commented on PR #856:
URL: https://github.com/apache/pulsar-client-go/pull/856#issuecomment-1264470377
@merlimat I agree it would be good to have a test like that, but it's a little difficult to set up because in order to have a module version, we would need to import this module from another module, but then we can't access the Version variable, because it's in the `internal` package.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] merlimat merged pull request #856: read module version info from golang runtime
Posted by GitBox <gi...@apache.org>.
merlimat merged PR #856:
URL: https://github.com/apache/pulsar-client-go/pull/856
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org