You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/09/15 21:04:20 UTC

[GitHub] [airflow] jghoman commented on a change in pull request #6105: [AIRFLOW-5495] Remove unneeded parens in dataproc.py

jghoman commented on a change in pull request #6105: [AIRFLOW-5495] Remove unneeded parens in dataproc.py
URL: https://github.com/apache/airflow/pull/6105#discussion_r324480968
 
 

 ##########
 File path: airflow/gcp/operators/dataproc.py
 ##########
 @@ -407,7 +407,7 @@ def _build_cluster_data(self):
             cluster_data['config']['softwareConfig']['imageVersion'] = self.image_version
 
         elif self.custom_image:
-            project_id = self.custom_image_project_id if (self.custom_image_project_id) else self.project_id
+            project_id = self.custom_image_project_id if self.custom_image_project_id else self.project_id
 
 Review comment:
   Hello from Guadalajara, @mik-laj ! We're running a new contributor hackathon.  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services