You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2007/03/30 23:19:04 UTC
DO NOT REPLY [Bug 42002] New: - Error when no JkWorkersFile used (JK 1.2.21)
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42002>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42002
Summary: Error when no JkWorkersFile used (JK 1.2.21)
Product: Tomcat 5
Version: Unknown
Platform: All
OS/Version: Linux
Status: NEW
Severity: regression
Priority: P2
Component: Native:JK
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: bruno.haleblian@free.fr
Hi,
As I upgraded from 1.2.19 to 1.2.21, I hit the following regression :
a Wrong [emerg] "Error in reading worker properties" is thrown because I don't
have any JkWorkersFile defined.
mod_jk.c should silently accept this, while the second part of test about empty
map looks correct.
I suggest following fix (wich works for me but may need more test) :
--- mod_jk.c.orig 2007-02-26 20:09:41.000000000 +0100
+++ mod_jk.c 2007-03-30 22:47:31.000000000 +0200
@@ -2658,17 +2658,16 @@
jk_set_worker_def_cache_size(mpm_threads);
/* if(map_alloc(&init_map)) { */
- if (!jk_map_read_properties(init_map, conf->worker_file, NULL, 1, conf->log)) {
- if (jk_map_size(init_map) == 0) {
- ap_log_error(APLOG_MARK, APLOG_STARTUP | APLOG_CRIT,
- 0, NULL,
- "No worker file and no worker options in httpd.conf"
- "use JkWorkerFile to set workers");
- }
+ if ((conf->worker_file!=NULL) && !jk_map_read_properties(init_map,
conf->worker_file, NULL, 1, conf->log)) {
ap_log_error(APLOG_MARK, APLOG_EMERG | APLOG_NOERRNO, 0, NULL, "Error
in reading worker properties");
return !OK;
}
-
+ if (jk_map_size(init_map) == 0) {
+ ap_log_error(APLOG_MARK, APLOG_STARTUP | APLOG_CRIT,
+ 0, NULL,
+ "No worker file and no worker options in httpd.conf"
+ "use JkWorkerFile to set workers");
+ }
if (jk_map_resolve_references(init_map, "worker.", 1, 1, conf->log) ==
JK_FALSE) {
ap_log_error(APLOG_MARK, APLOG_EMERG | APLOG_NOERRNO, 0, NULL, "Error
in resolving configuration references");
return !OK;
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 42002] - Error when no JkWorkersFile used (JK 1.2.21)
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42002>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42002
------- Additional Comments From bruno.haleblian@free.fr 2007-03-30 14:33 -------
Some more data about my platform may helps :
32bits RedHat ES4 Update4 (Linux 2.6.9-42.ELsmp) - Apache/2.0.52 - "worker" mode
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 42002] - Error when no JkWorkersFile used (JK 1.2.21)
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42002>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42002
------- Additional Comments From bruno.haleblian@free.fr 2007-03-31 06:23 -------
(In reply to comment #2)
>
> *** This bug has been marked as a duplicate of 41770 ***
Oops for not reading BZDB correctly, just missed it, sorry!
Grepping the die message took so close to this quick fix...
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 42002] - Error when no JkWorkersFile used (JK 1.2.21)
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42002>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42002
mturk@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |DUPLICATE
------- Additional Comments From mturk@apache.org 2007-03-31 00:00 -------
*** This bug has been marked as a duplicate of 41770 ***
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 42002] - Error when no JkWorkersFile used (JK 1.2.21)
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42002>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42002
rainer.jung@kippdata.de changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |CLOSED
------- Additional Comments From rainer.jung@kippdata.de 2008-01-01 17:03 -------
Move a couple of fixed JK issues from resolved to closed.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org