You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by GitBox <gi...@apache.org> on 2020/07/04 13:49:59 UTC
[GitHub] [httpcomponents-core] nielsbasjes opened a new pull request #200: Add Automatic-Module-Name in manifest so Java9 modular applications c…
nielsbasjes opened a new pull request #200:
URL: https://github.com/apache/httpcomponents-core/pull/200
…an depend on this library
This is essentially a duplication of https://github.com/apache/httpcomponents-core/pull/65 but now for the 5.x versions.
As indicated here https://github.com/apache/httpcomponents-client/pull/104#issuecomment-403436258 I have made sure the module names to not contain a hyphen ('-').
Looking at what was done for the 4.x version I have chosen to stick as close as possible to essentially `groupdId.artifactId` as possible.
Please indicate if this is the right choice or if you want something different.
I see this as a very important choice to get right at this point as it is something I expect will be hard to change in the future.
I added this to ALL maven artifacts (also the -testing), please asses if this is correct.
Please commit this into both master and the 5.1.x branch if you agree with these changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] michael-o commented on pull request #200: Add Automatic-Module-Name in manifest so Java9 modular applications c…
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #200:
URL: https://github.com/apache/httpcomponents-core/pull/200#issuecomment-653910763
Same opinion here as for httpclient5.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] ok2c commented on pull request #200: Add Automatic-Module-Name in manifest so Java9 modular applications c…
Posted by GitBox <gi...@apache.org>.
ok2c commented on pull request #200:
URL: https://github.com/apache/httpcomponents-core/pull/200#issuecomment-654193720
> Isn't there a way to do this once? Say in the parent POM and each module POM can define a property used from the parent.
@nielsbasjes Is there a chance to collapse multiple plugin declarations in module POMs into a single one in the top project POM?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] nielsbasjes commented on pull request #200: Add Automatic-Module-Name in manifest so Java9 modular applications c…
Posted by GitBox <gi...@apache.org>.
nielsbasjes commented on pull request #200:
URL: https://github.com/apache/httpcomponents-core/pull/200#issuecomment-654255935
@ok2c I was able to simplify the code change as you suggested. I also made the same change for the other PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] ok2c commented on pull request #200: Add Automatic-Module-Name in manifest so Java9 modular applications c…
Posted by GitBox <gi...@apache.org>.
ok2c commented on pull request #200:
URL: https://github.com/apache/httpcomponents-core/pull/200#issuecomment-654352509
@michael-o @garydgregory If I hear no objections I will merge this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] ok2c commented on pull request #200: Add Automatic-Module-Name in manifest so Java9 modular applications c…
Posted by GitBox <gi...@apache.org>.
ok2c commented on pull request #200:
URL: https://github.com/apache/httpcomponents-core/pull/200#issuecomment-653903649
Folks, any objection to the proposed changes?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] ok2c merged pull request #200: Add Automatic-Module-Name in manifest so Java9 modular applications c…
Posted by GitBox <gi...@apache.org>.
ok2c merged pull request #200:
URL: https://github.com/apache/httpcomponents-core/pull/200
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] nielsbasjes commented on pull request #200: Add Automatic-Module-Name in manifest so Java9 modular applications c…
Posted by GitBox <gi...@apache.org>.
nielsbasjes commented on pull request #200:
URL: https://github.com/apache/httpcomponents-core/pull/200#issuecomment-654216392
@ok2c Perhaps this can be done. I'll experiment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] nielsbasjes commented on pull request #200: Add Automatic-Module-Name in manifest so Java9 modular applications c…
Posted by GitBox <gi...@apache.org>.
nielsbasjes commented on pull request #200:
URL: https://github.com/apache/httpcomponents-core/pull/200#issuecomment-653769038
Note that I have created the same change for both [httpcomponents-core](https://github.com/apache/httpcomponents-core/pull/200) and [httpcomponents-client](https://github.com/apache/httpcomponents-client/pull/234).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] garydgregory commented on pull request #200: Add Automatic-Module-Name in manifest so Java9 modular applications c…
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #200:
URL: https://github.com/apache/httpcomponents-core/pull/200#issuecomment-653909580
Isn't there a way to do this once? Say in the parent POM and each module POM can define a property used from the parent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org