You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2018/06/01 03:28:31 UTC
Re: Review Request 67381: Added `cgroups/all` into CHANGELOG and
upgrades.md.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67381/
-----------------------------------------------------------
(Updated June 1, 2018, 11:28 a.m.)
Review request for mesos and Gilbert Song.
Changes
-------
Rebased.
Bugs: MESOS-7691
https://issues.apache.org/jira/browse/MESOS-7691
Repository: mesos
Description
-------
Added `cgroups/all` into CHANGELOG and upgrades.md.
Diffs (updated)
-----
CHANGELOG bdcf8e33b95f4bea04b64417aa73df44dd456afe
docs/upgrades.md 18632edd20fcf943c6e7147aca3fec5b5521f14f
Diff: https://reviews.apache.org/r/67381/diff/2/
Changes: https://reviews.apache.org/r/67381/diff/1-2/
Testing
-------
Not a code change.
Thanks,
Qian Zhang
Re: Review Request 67381: Added `cgroups/all` into CHANGELOG and
upgrades.md.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67381/#review204167
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 67335.
Failed command: `python.exe .\support\python3\apply-reviews.py -n -r 67335`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67381
Relevant logs:
- [apply-review-67335-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67381/logs/apply-review-67335-stdout.log):
```
error: patch failed: docs/configuration/agent.md:967
error: docs/configuration/agent.md: patch does not apply
```
- Mesos Reviewbot Windows
On June 1, 2018, 11:28 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67381/
> -----------------------------------------------------------
>
> (Updated June 1, 2018, 11:28 a.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Bugs: MESOS-7691
> https://issues.apache.org/jira/browse/MESOS-7691
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added `cgroups/all` into CHANGELOG and upgrades.md.
>
>
> Diffs
> -----
>
> CHANGELOG bdcf8e33b95f4bea04b64417aa73df44dd456afe
> docs/upgrades.md 18632edd20fcf943c6e7147aca3fec5b5521f14f
>
>
> Diff: https://reviews.apache.org/r/67381/diff/2/
>
>
> Testing
> -------
>
> Not a code change.
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 67381: Added `cgroups/all` into CHANGELOG and
upgrades.md.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67381/#review204693
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 67335.
Failed command: `python.exe .\support\python3\apply-reviews.py -n -r 67335`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67381
Relevant logs:
- [apply-review-67335-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67381/logs/apply-review-67335-stdout.log):
```
error: patch failed: docs/configuration/agent.md:967
error: docs/configuration/agent.md: patch does not apply
```
- Mesos Reviewbot Windows
On June 13, 2018, 2:26 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67381/
> -----------------------------------------------------------
>
> (Updated June 13, 2018, 2:26 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Bugs: MESOS-7691
> https://issues.apache.org/jira/browse/MESOS-7691
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added `cgroups/all` into CHANGELOG and upgrades.md.
>
>
> Diffs
> -----
>
> CHANGELOG 0c45af66cbe1c6feede328143d30dad4eaf1a4b3
> docs/upgrades.md 18632edd20fcf943c6e7147aca3fec5b5521f14f
>
>
> Diff: https://reviews.apache.org/r/67381/diff/3/
>
>
> Testing
> -------
>
> Not a code change.
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 67381: Added `cgroups/all` into CHANGELOG and
upgrades.md.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67381/#review204982
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On June 13, 2018, 6:41 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67381/
> -----------------------------------------------------------
>
> (Updated June 13, 2018, 6:41 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Bugs: MESOS-7691
> https://issues.apache.org/jira/browse/MESOS-7691
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added `cgroups/all` into CHANGELOG and upgrades.md.
>
>
> Diffs
> -----
>
> CHANGELOG 0c45af66cbe1c6feede328143d30dad4eaf1a4b3
> docs/upgrades.md 18632edd20fcf943c6e7147aca3fec5b5521f14f
>
>
> Diff: https://reviews.apache.org/r/67381/diff/4/
>
>
> Testing
> -------
>
> Not a code change.
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 67381: Added `cgroups/all` into CHANGELOG and
upgrades.md.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67381/#review204756
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 67335.
Failed command: `python.exe .\support\python3\apply-reviews.py -n -r 67335`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67381
Relevant logs:
- [apply-review-67335-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67381/logs/apply-review-67335-stdout.log):
```
error: patch failed: docs/configuration/agent.md:967
error: docs/configuration/agent.md: patch does not apply
```
- Mesos Reviewbot Windows
On June 14, 2018, 1:41 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67381/
> -----------------------------------------------------------
>
> (Updated June 14, 2018, 1:41 a.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Bugs: MESOS-7691
> https://issues.apache.org/jira/browse/MESOS-7691
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added `cgroups/all` into CHANGELOG and upgrades.md.
>
>
> Diffs
> -----
>
> CHANGELOG 0c45af66cbe1c6feede328143d30dad4eaf1a4b3
> docs/upgrades.md 18632edd20fcf943c6e7147aca3fec5b5521f14f
>
>
> Diff: https://reviews.apache.org/r/67381/diff/4/
>
>
> Testing
> -------
>
> Not a code change.
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 67381: Added `cgroups/all` into CHANGELOG and
upgrades.md.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67381/
-----------------------------------------------------------
(Updated June 14, 2018, 9:41 a.m.)
Review request for mesos and Gilbert Song.
Bugs: MESOS-7691
https://issues.apache.org/jira/browse/MESOS-7691
Repository: mesos
Description
-------
Added `cgroups/all` into CHANGELOG and upgrades.md.
Diffs (updated)
-----
CHANGELOG 0c45af66cbe1c6feede328143d30dad4eaf1a4b3
docs/upgrades.md 18632edd20fcf943c6e7147aca3fec5b5521f14f
Diff: https://reviews.apache.org/r/67381/diff/4/
Changes: https://reviews.apache.org/r/67381/diff/3-4/
Testing
-------
Not a code change.
Thanks,
Qian Zhang
Re: Review Request 67381: Added `cgroups/all` into CHANGELOG and
upgrades.md.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67381/
-----------------------------------------------------------
(Updated June 13, 2018, 10:26 p.m.)
Review request for mesos and Gilbert Song.
Bugs: MESOS-7691
https://issues.apache.org/jira/browse/MESOS-7691
Repository: mesos
Description
-------
Added `cgroups/all` into CHANGELOG and upgrades.md.
Diffs (updated)
-----
CHANGELOG 0c45af66cbe1c6feede328143d30dad4eaf1a4b3
docs/upgrades.md 18632edd20fcf943c6e7147aca3fec5b5521f14f
Diff: https://reviews.apache.org/r/67381/diff/3/
Changes: https://reviews.apache.org/r/67381/diff/2-3/
Testing
-------
Not a code change.
Thanks,
Qian Zhang
Re: Review Request 67381: Added `cgroups/all` into CHANGELOG and
upgrades.md.
Posted by Qian Zhang <zh...@gmail.com>.
> On June 7, 2018, 7:50 a.m., Gilbert Song wrote:
> > docs/upgrades.md
> > Lines 451 (patched)
> > <https://reviews.apache.org/r/67381/diff/2/?file=2034251#file2034251line451>
> >
> > s/causes/allows/g?
> >
> > Could you also emphasize that the default behavior does not change?
Did you mean the default behavior of the agent flag `--isolaton` does not change if the option `cgroups/all` is not specified?
- Qian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67381/#review204439
-----------------------------------------------------------
On June 1, 2018, 11:28 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67381/
> -----------------------------------------------------------
>
> (Updated June 1, 2018, 11:28 a.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Bugs: MESOS-7691
> https://issues.apache.org/jira/browse/MESOS-7691
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added `cgroups/all` into CHANGELOG and upgrades.md.
>
>
> Diffs
> -----
>
> CHANGELOG bdcf8e33b95f4bea04b64417aa73df44dd456afe
> docs/upgrades.md 18632edd20fcf943c6e7147aca3fec5b5521f14f
>
>
> Diff: https://reviews.apache.org/r/67381/diff/2/
>
>
> Testing
> -------
>
> Not a code change.
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 67381: Added `cgroups/all` into CHANGELOG and
upgrades.md.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67381/#review204439
-----------------------------------------------------------
Fix it, then Ship it!
docs/upgrades.md
Lines 451 (patched)
<https://reviews.apache.org/r/67381/#comment286937>
s/causes/allows/g?
Could you also emphasize that the default behavior does not change?
- Gilbert Song
On May 31, 2018, 8:28 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67381/
> -----------------------------------------------------------
>
> (Updated May 31, 2018, 8:28 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Bugs: MESOS-7691
> https://issues.apache.org/jira/browse/MESOS-7691
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added `cgroups/all` into CHANGELOG and upgrades.md.
>
>
> Diffs
> -----
>
> CHANGELOG bdcf8e33b95f4bea04b64417aa73df44dd456afe
> docs/upgrades.md 18632edd20fcf943c6e7147aca3fec5b5521f14f
>
>
> Diff: https://reviews.apache.org/r/67381/diff/2/
>
>
> Testing
> -------
>
> Not a code change.
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 67381: Added `cgroups/all` into CHANGELOG and
upgrades.md.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67381/#review204179
-----------------------------------------------------------
Bad patch!
Reviews applied: [67381, 67358, 67343, 67342, 67335]
Failed command: python support/apply-reviews.py -n -r 67335
Error:
The support scripts will be upgraded to Python 3 by July 1st.
Make sure to install Python 3.6 on your machine before.
2018-06-01 12:56:02 URL:https://reviews.apache.org/r/67335/diff/raw/ [1167/1167] -> "67335.patch" [1]
error: patch failed: docs/configuration/agent.md:967
error: docs/configuration/agent.md: patch does not apply
Full log: https://builds.apache.org/job/Mesos-Reviewbot/22607/console
- Mesos Reviewbot
On June 1, 2018, 3:28 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67381/
> -----------------------------------------------------------
>
> (Updated June 1, 2018, 3:28 a.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Bugs: MESOS-7691
> https://issues.apache.org/jira/browse/MESOS-7691
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added `cgroups/all` into CHANGELOG and upgrades.md.
>
>
> Diffs
> -----
>
> CHANGELOG bdcf8e33b95f4bea04b64417aa73df44dd456afe
> docs/upgrades.md 18632edd20fcf943c6e7147aca3fec5b5521f14f
>
>
> Diff: https://reviews.apache.org/r/67381/diff/2/
>
>
> Testing
> -------
>
> Not a code change.
>
>
> Thanks,
>
> Qian Zhang
>
>