You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Johan Oskarsson (JIRA)" <ji...@apache.org> on 2009/05/12 18:51:45 UTC
[jira] Created: (CASSANDRA-164) Fix junit related build issues
Fix junit related build issues
------------------------------
Key: CASSANDRA-164
URL: https://issues.apache.org/jira/browse/CASSANDRA-164
Project: Cassandra
Issue Type: Bug
Reporter: Johan Oskarsson
Attachments: CASSANDRA-164.patch
Since the junit switch no xml report files are generated and the build doesn't fail properly if a test fails
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-164) Fix junit related build issues
Posted by "Johan Oskarsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708841#action_12708841 ]
Johan Oskarsson commented on CASSANDRA-164:
-------------------------------------------
The problem is that then we won't get the junit xml files, which means hudson can't pick them up and tell us what went wrong. I'll see if we can get both.
As a side note I wish you wouldn't commit patches with additional, non reviewed changes. Personally I think it's better to comment on the issue and let the developer make the changes or argue a case against them.
> Fix junit related build issues
> ------------------------------
>
> Key: CASSANDRA-164
> URL: https://issues.apache.org/jira/browse/CASSANDRA-164
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.3
> Reporter: Johan Oskarsson
> Assignee: Johan Oskarsson
> Fix For: 0.3
>
> Attachments: CASSANDRA-164.patch
>
>
> Since the junit switch no xml report files are generated and the build doesn't fail properly if a test fails
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-164) Fix junit related build issues
Posted by "Johan Oskarsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708843#action_12708843 ]
Johan Oskarsson commented on CASSANDRA-164:
-------------------------------------------
Guess I spoke to soon, the xml one is there too. My other comment still stands though :)
> Fix junit related build issues
> ------------------------------
>
> Key: CASSANDRA-164
> URL: https://issues.apache.org/jira/browse/CASSANDRA-164
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.3
> Reporter: Johan Oskarsson
> Assignee: Johan Oskarsson
> Fix For: 0.3
>
> Attachments: CASSANDRA-164.patch
>
>
> Since the junit switch no xml report files are generated and the build doesn't fail properly if a test fails
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-164) Fix junit related build issues
Posted by "Johan Oskarsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Johan Oskarsson updated CASSANDRA-164:
--------------------------------------
Attachment: CASSANDRA-164.patch
> Fix junit related build issues
> ------------------------------
>
> Key: CASSANDRA-164
> URL: https://issues.apache.org/jira/browse/CASSANDRA-164
> Project: Cassandra
> Issue Type: Bug
> Reporter: Johan Oskarsson
> Attachments: CASSANDRA-164.patch
>
>
> Since the junit switch no xml report files are generated and the build doesn't fail properly if a test fails
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-164) Fix junit related build issues
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708955#action_12708955 ]
Jonathan Ellis commented on CASSANDRA-164:
------------------------------------------
> I wish you wouldn't commit patches with additional, non reviewed changes
Refrain from judgement for a moment and let's look at how the workflow compares.
Without taking shortcuts:
If my change is good:
1) original patch uploaded
2) my patch uploaded
3) my patch approved
4) commit
If my change is not good:
1) original patch uploaded
2) my patch uploaded
3) new patch from reviewer
4) commit
(obviously repeat 2-3 as necessary, let's keep things simple though).
Now, with shortcuts:
If my change is good:
1) original patch uploaded
2) commit patch w/ my changes
If my change is not good:
1) original patch uploaded
2) commit patch w/ my changes
3) new patch from reviewer against my commit
4) commit new patch
So in the case where my change is not good, we have basically the same steps and our only loss is an extra svn commit at step 2.
But when my change _is_ good we cut the steps where someone is waiting on someone else in half.
That seems like the risk is worth it to me. (And my track record is very good here; I can't remember ever making a change that the author/reviewer disagreed with. Part of that is if I make a nontrivial change I do in fact upload patches first.)
> Fix junit related build issues
> ------------------------------
>
> Key: CASSANDRA-164
> URL: https://issues.apache.org/jira/browse/CASSANDRA-164
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.3
> Reporter: Johan Oskarsson
> Assignee: Johan Oskarsson
> Fix For: 0.3
>
> Attachments: CASSANDRA-164.patch
>
>
> Since the junit switch no xml report files are generated and the build doesn't fail properly if a test fails
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-164) Fix junit related build issues
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708849#action_12708849 ]
Hudson commented on CASSANDRA-164:
----------------------------------
Integrated in Cassandra #73 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/73/])
fix junit-related build issues. patch by johano; reviewed by jbellis for
> Fix junit related build issues
> ------------------------------
>
> Key: CASSANDRA-164
> URL: https://issues.apache.org/jira/browse/CASSANDRA-164
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.3
> Reporter: Johan Oskarsson
> Assignee: Johan Oskarsson
> Fix For: 0.3
>
> Attachments: CASSANDRA-164.patch
>
>
> Since the junit switch no xml report files are generated and the build doesn't fail properly if a test fails
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-164) Fix junit related build issues
Posted by "Johan Oskarsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708959#action_12708959 ]
Johan Oskarsson commented on CASSANDRA-164:
-------------------------------------------
I know we are not going to agree on this, but wanted to throw it out there anyway.
I didn't mean that you as a committer should upload a new, revised patch, that would be quite a workload. Instead what I was suggesting was that you suggest the changes needed in the ticket, wait for the developer to either submit a new patch or discuss your suggested changes.
It's not that I don't trust your code changes. The main reason is that imho the latest patch in jira should be the one applied to svn for a few reasons, transparency being one and from my experience it is very helpful for power users to be able to download the patch and apply it to older versions of the software. We do this all the time at Last.fm with our Hadoop installation.
I'm not going to push this further, just wanted it said.
> Fix junit related build issues
> ------------------------------
>
> Key: CASSANDRA-164
> URL: https://issues.apache.org/jira/browse/CASSANDRA-164
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.3
> Reporter: Johan Oskarsson
> Assignee: Johan Oskarsson
> Fix For: 0.3
>
> Attachments: CASSANDRA-164.patch
>
>
> Since the junit switch no xml report files are generated and the build doesn't fail properly if a test fails
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.