You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "paul-rogers (via GitHub)" <gi...@apache.org> on 2023/02/09 02:42:12 UTC
[GitHub] [druid] paul-rogers opened a new pull request, #13778: Code cleanup & message improvements
paul-rogers opened a new pull request, #13778:
URL: https://github.com/apache/druid/pull/13778
This PR is a collection if minor edits done as part of the Catalog project. Pulled out here to reduce the size of the catalog PR.
The edits include:
* Fix spacing
* Add type parameters to some types that omit them (to prevent the IDE from flagging spurious warnings)
* Add `toString()` methods to formats so tests compare correctly. Without this, an UT with an external data source will fail if the two formats are not the same object. The change allows comparison as long as the two formats have identical values.
* IT doc revisions
* Error message edits
* Display UT query results when tests fail. This makes it easy to copy/paste the correct results into the test.
* When creating alert records, omit the `query` field if it is `null`. (Else, the original error is masked by an NPE in the logging code.)
No substantial changes are in the PR.
#### Release note
No user-visible changes.
<hr>
This PR has:
- [X] been self-reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] github-code-scanning[bot] commented on a diff in pull request #13778: Code cleanup & message improvements
Posted by "github-code-scanning[bot] (via GitHub)" <gi...@apache.org>.
github-code-scanning[bot] commented on code in PR #13778:
URL: https://github.com/apache/druid/pull/13778#discussion_r1103890064
##########
core/src/main/java/org/apache/druid/data/input/impl/FlatTextInputFormat.java:
##########
@@ -143,4 +143,16 @@
{
return Objects.hash(listDelimiter, columns, findColumnsFromHeader, skipHeaderRows, delimiter);
}
+
+ protected String fieldsToString()
+ {
+ return "FlatTextInputFormat{"
+ + "delimiter=\"" + delimiter
+ + "\"listDelimiter="
+ + listDelimiter == null ? "null" : "\"" + listDelimiter + "\""
Review Comment:
## Useless null check
This check is useless, since [... + ...](1) always is non-null.
[Show more details](https://github.com/apache/druid/security/code-scanning/4264)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhishekagarwal87 merged pull request #13778: Code cleanup & message improvements
Posted by "abhishekagarwal87 (via GitHub)" <gi...@apache.org>.
abhishekagarwal87 merged PR #13778:
URL: https://github.com/apache/druid/pull/13778
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org